Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: src/debug/debug.cc

Issue 1369293003: Wrap JSFunction bindings in a helper object (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/api.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/debug.h" 5 #include "src/debug/debug.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 728 matching lines...) Expand 10 before | Expand all | Expand 10 after
739 739
740 // Flood the function with break points. 740 // Flood the function with break points.
741 Handle<DebugInfo> debug_info(shared->GetDebugInfo()); 741 Handle<DebugInfo> debug_info(shared->GetDebugInfo());
742 for (BreakLocation::Iterator it(debug_info, type); !it.Done(); it.Next()) { 742 for (BreakLocation::Iterator it(debug_info, type); !it.Done(); it.Next()) {
743 it.GetBreakLocation().SetOneShot(); 743 it.GetBreakLocation().SetOneShot();
744 } 744 }
745 } 745 }
746 746
747 747
748 void Debug::FloodBoundFunctionWithOneShot(Handle<JSFunction> function) { 748 void Debug::FloodBoundFunctionWithOneShot(Handle<JSFunction> function) {
749 Handle<FixedArray> new_bindings(function->function_bindings()); 749 Handle<BindingsArray> new_bindings(function->function_bindings());
750 Handle<Object> bindee(new_bindings->get(JSFunction::kBoundFunctionIndex), 750 Handle<Object> bindee(new_bindings->bound_function(), isolate_);
751 isolate_);
752 751
753 if (!bindee.is_null() && bindee->IsJSFunction()) { 752 if (!bindee.is_null() && bindee->IsJSFunction()) {
754 Handle<JSFunction> bindee_function(JSFunction::cast(*bindee)); 753 Handle<JSFunction> bindee_function(JSFunction::cast(*bindee));
755 FloodWithOneShotGeneric(bindee_function); 754 FloodWithOneShotGeneric(bindee_function);
756 } 755 }
757 } 756 }
758 757
759 758
760 void Debug::FloodDefaultConstructorWithOneShot(Handle<JSFunction> function) { 759 void Debug::FloodDefaultConstructorWithOneShot(Handle<JSFunction> function) {
761 DCHECK(function->shared()->is_default_constructor()); 760 DCHECK(function->shared()->is_default_constructor());
(...skipping 1818 matching lines...) Expand 10 before | Expand all | Expand 10 after
2580 } 2579 }
2581 2580
2582 2581
2583 void LockingCommandMessageQueue::Clear() { 2582 void LockingCommandMessageQueue::Clear() {
2584 base::LockGuard<base::Mutex> lock_guard(&mutex_); 2583 base::LockGuard<base::Mutex> lock_guard(&mutex_);
2585 queue_.Clear(); 2584 queue_.Clear();
2586 } 2585 }
2587 2586
2588 } // namespace internal 2587 } // namespace internal
2589 } // namespace v8 2588 } // namespace v8
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698