Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1369273003: GYP: Don't pass -Wno-format-pedantic to GCC. (Closed)

Created:
5 years, 2 months ago by akos.palfi.imgtec
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

GYP: Don't pass -Wno-format-pedantic to GCC. This flag is not understood correctly by GCC and breaks the GCC ARM and MIPS optdebug builds. Patch from Brendan Kirby <brendan.kirby@imgtec.com>; BUG= Committed: https://crrev.com/d7f813b4da929a42713b4bacd6a266ade742a41e Cr-Commit-Position: refs/heads/master@{#31013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M build/standalone.gypi View 1 chunk +19 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
paul.l...
My LGTM doesn't work here, can you guys take a look? I saw ARM gcc ...
5 years, 2 months ago (2015-09-29 16:51:33 UTC) #2
Michael Achenbach
lgtm
5 years, 2 months ago (2015-09-29 18:09:54 UTC) #3
Michael Achenbach
Thanks for this - was annoying for a while!
5 years, 2 months ago (2015-09-29 18:10:24 UTC) #4
Michael Achenbach
Thanks for this - was annoying for a while!
5 years, 2 months ago (2015-09-29 18:10:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369273003/1
5 years, 2 months ago (2015-09-29 21:45:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 22:10:18 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 22:10:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7f813b4da929a42713b4bacd6a266ade742a41e
Cr-Commit-Position: refs/heads/master@{#31013}

Powered by Google App Engine
This is Rietveld 408576698