Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2445)

Unified Diff: build/standalone.gypi

Issue 1369273003: GYP: Don't pass -Wno-format-pedantic to GCC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index 1654be2786301d8c6aee788a5912536d7e44c594..7250579d27c123d40697647f38605ad34ce5683e 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -412,8 +412,25 @@
# things when their commandline changes). Nothing should ever read this
# define.
'defines': ['CR_CLANG_REVISION=<!(<(DEPTH)/tools/clang/scripts/update.sh --print-revision)'],
- 'cflags+': [
- '-Wno-format-pedantic',
+ 'conditions': [
+ ['host_clang==1', {
+ 'target_conditions': [
+ ['_toolset=="host"', {
+ 'cflags+': [
+ '-Wno-format-pedantic',
+ ],
+ }],
+ ],
+ }],
+ ['clang==1', {
+ 'target_conditions': [
+ ['_toolset=="target"', {
+ 'cflags+': [
+ '-Wno-format-pedantic',
+ ],
+ }],
+ ],
+ }],
],
}],
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698