Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1369203003: Promote PPB_VideoDecoder 1.1 to Stable (Closed)

Created:
5 years, 2 months ago by lpique
Modified:
5 years, 2 months ago
Reviewers:
*bbudge
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, jam, teravest+watch_chromium.org, darin-cc_chromium.org, bradnelson+warch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Promote PPB_VideoDecoder 1.1 to Stable Works just fine in ARC. BUG=520323 Committed: https://crrev.com/636e3cf3ccde41fa156c7483f9ebcc59cee21378 Cr-Commit-Position: refs/heads/master@{#355667}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Corrected interface order in interfaces_ppb_public_stable.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -18 lines) Patch
M content/renderer/pepper/pepper_video_decoder_host.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ppapi/api/ppb_video_decoder.idl View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/ppb_video_decoder.h View 5 chunks +6 lines, -6 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev_channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/thunk/interfaces_ppb_public_stable.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
lpique
PTAL. I'm not sure if there is any other review required for this promotion.
5 years, 2 months ago (2015-09-28 23:50:12 UTC) #3
bbudge
Looks good but we should have an API review before landing. I'll post on pepper-dev. ...
5 years, 2 months ago (2015-09-29 00:07:52 UTC) #4
lpique
https://codereview.chromium.org/1369203003/diff/1/ppapi/thunk/interfaces_ppb_public_stable.h File ppapi/thunk/interfaces_ppb_public_stable.h (right): https://codereview.chromium.org/1369203003/diff/1/ppapi/thunk/interfaces_ppb_public_stable.h#newcode100 ppapi/thunk/interfaces_ppb_public_stable.h:100: PROXIED_IFACE(PPB_VIDEODECODER_INTERFACE_1_1, PPB_VideoDecoder_1_1) On 2015/09/29 00:07:52, bbudge wrote: > nit: ...
5 years, 2 months ago (2015-09-29 00:28:44 UTC) #5
bbudge
lgtm
5 years, 2 months ago (2015-09-29 13:48:52 UTC) #6
lpique
On 2015/09/29 13:48:52, bbudge wrote: > lgtm FYI - I'm not subscribed to pepper-dev (I ...
5 years, 2 months ago (2015-10-21 17:43:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369203003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369203003/20001
5 years, 2 months ago (2015-10-22 22:34:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-22 23:20:50 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 23:21:29 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/636e3cf3ccde41fa156c7483f9ebcc59cee21378
Cr-Commit-Position: refs/heads/master@{#355667}

Powered by Google App Engine
This is Rietveld 408576698