Port most of the remainder of //tools/android from GYP to GN

Port most of the remainder of //tools/android from GYP to GN

BUG=535389
TEST=None

Committed: https://crrev.com/8b9d18cc05682b6e1a0faaa666a163f55f7a77d1
Cr-Commit-Position: refs/heads/master@{#352282}

[pkotwicz, 2015-09-27 18:19:17]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2015-09-27 18:29:22]

pkotwicz@chromium.org changed reviewers:
+ agrieve@chromium.org

[pkotwicz, 2015-09-27 18:29:23]

agrieve@ PTAL

[agrieve, 2015-09-28 14:58:54]

lgtm

https://codereview.chromium.org/1369153002/diff/20001/tools/android/heap_prof...
File tools/android/heap_profiler/BUILD.gn (right):

https://codereview.chromium.org/1369153002/diff/20001/tools/android/heap_prof...
tools/android/heap_profiler/BUILD.gn:16: static_library("heap_profiler_core") {
nit: use source_set if possible

[pkotwicz, 2015-09-28 21:02:23]

Patchset #2 (id:40001) has been deleted

[pkotwicz, 2015-09-28 21:03:05]

pkotwicz@chromium.org changed reviewers:
+ yfriedman@chromium.org

[pkotwicz, 2015-09-28 21:03:05]

Yaron, can you please take a look at tools/android ?

[Yaron, 2015-09-28 21:35:25]

needs BUILD.gn owner

https://codereview.chromium.org/1369153002/diff/60001/tools/android/BUILD.gn
File tools/android/BUILD.gn (right):

https://codereview.chromium.org/1369153002/diff/60001/tools/android/BUILD.gn#...
tools/android/BUILD.gn:11: "//tools/android/adb_reboot",
Could you replace most of this with: "//tools/android/*" ?

https://codereview.chromium.org/1369153002/diff/60001/tools/android/heap_prof...
File tools/android/heap_profiler/BUILD.gn (right):

https://codereview.chromium.org/1369153002/diff/60001/tools/android/heap_prof...
tools/android/heap_profiler/BUILD.gn:7: shared_library("heap_profiler") {
Do you need to annotate the corresponding gyp files with a comment so we know
the transition is done? (aside: is that just for humans or does a tool actually
consume that and check?)

https://codereview.chromium.org/1369153002/diff/60001/tools/android/heap_prof...
tools/android/heap_profiler/BUILD.gn:43: executable("heap_integrationtest") {
Are executables automatically stripped on android? Presumably it's done cause
with debug symbols it's too slow to transfer to the device

[pkotwicz, 2015-09-29 14:10:49]

https://codereview.chromium.org/1369153002/diff/60001/tools/android/heap_prof...
File tools/android/heap_profiler/BUILD.gn (right):

https://codereview.chromium.org/1369153002/diff/60001/tools/android/heap_prof...
tools/android/heap_profiler/BUILD.gn:43: executable("heap_integrationtest") {
It looks like it. heap_integrationtest is present in out/gn_Debug/exe.unstripped
build/toolchain/gcc_toolchain.gni offers support for stripping executables

[pkotwicz, 2015-09-29 14:24:52]

yfriedman@ can you please take another look?

https://codereview.chromium.org/1369153002/diff/60001/tools/android/BUILD.gn
File tools/android/BUILD.gn (right):

https://codereview.chromium.org/1369153002/diff/60001/tools/android/BUILD.gn#...
tools/android/BUILD.gn:11: "//tools/android/adb_reboot",
I am not sure if the intent of the android_tools target is to build all
subdirectories. It currently does not for GYP.

https://codereview.chromium.org/1369153002/diff/60001/tools/android/heap_prof...
File tools/android/heap_profiler/BUILD.gn (right):

https://codereview.chromium.org/1369153002/diff/60001/tools/android/heap_prof...
tools/android/heap_profiler/BUILD.gn:7: shared_library("heap_profiler") {
I asked agrieve@ and he is not aware of any scripts which consume the comments.
BUILD.gn in the root src directory is as close to a listing of what's left to be
converted that I know of. Most BUILD.gn files do not have comments

[Yaron, 2015-09-29 16:52:22]

lgtm

I think it's worth cleaning it up but it's also not worth arguing over if you
feel strongly

https://codereview.chromium.org/1369153002/diff/60001/tools/android/BUILD.gn
File tools/android/BUILD.gn (right):

https://codereview.chromium.org/1369153002/diff/60001/tools/android/BUILD.gn#...
tools/android/BUILD.gn:11: "//tools/android/adb_reboot",
On 2015/09/29 14:24:52, pkotwicz wrote:
> I am not sure if the intent of the android_tools target is to build all
> subdirectories. It currently does not for GYP.

I'm fairly certain it was when we first added it :)
I expect it not matching was an accident

[pkotwicz, 2015-09-29 17:47:13]

pkotwicz@chromium.org changed reviewers:
+ dpranke@chromium.org

[pkotwicz, 2015-09-29 17:47:13]

dpranke@ can you please take a look at the change in the root BUILD.gn ?

[Dirk Pranke, 2015-09-29 22:41:27]

lgtm.

https://codereview.chromium.org/1369153002/diff/60001/tools/android/BUILD.gn
File tools/android/BUILD.gn (right):

https://codereview.chromium.org/1369153002/diff/60001/tools/android/BUILD.gn#...
tools/android/BUILD.gn:11: "//tools/android/adb_reboot",
On 2015/09/29 16:52:22, Yaron wrote:
> On 2015/09/29 14:24:52, pkotwicz wrote:
> > I am not sure if the intent of the android_tools target is to build all
> > subdirectories. It currently does not for GYP.
> 
> I'm fairly certain it was when we first added it :)
> I expect it not matching was an accident 

You can't replace it with //tools/android/* because GN does not support
wildcards.

You should not use wildcards in GYP either, because wildcards can cause weird
things to get slurped in :).

https://codereview.chromium.org/1369153002/diff/60001/tools/android/heap_prof...
File tools/android/heap_profiler/BUILD.gn (right):

https://codereview.chromium.org/1369153002/diff/60001/tools/android/heap_prof...
tools/android/heap_profiler/BUILD.gn:7: shared_library("heap_profiler") {
On 2015/09/29 14:24:52, pkotwicz wrote:
> I asked agrieve@ and he is not aware of any scripts which consume the
comments.
> BUILD.gn in the root src directory is as close to a listing of what's left to
be
> converted that I know of. Most BUILD.gn files do not have comments

Correct. There is no need to annotate something to indicate that a file or group
is done, we just label individual targets where possible.

[pkotwicz, 2015-09-30 15:49:36]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-09-30 15:49:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
agrieve@chromium.org, dpranke@chromium.org, yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1369153002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-09-30 15:50:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1369153002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1369153002/80001

[commit-bot: I haz the power, 2015-09-30 15:57:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 15:57:02]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pkotwicz, 2015-10-04 20:32:14]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-10-04 20:32:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, yfriedman@chromium.org, agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/1369153002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-10-04 20:32:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1369153002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1369153002/120001

[commit-bot: I haz the power, 2015-10-04 21:00:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-04 21:00:10]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[pkotwicz, 2015-10-05 00:27:47]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-10-05 00:27:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, yfriedman@chromium.org, agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/1369153002/#ps80002
(title: " ")

[commit-bot: I haz the power, 2015-10-05 00:27:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1369153002/80002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1369153002/80002

[commit-bot: I haz the power, 2015-10-05 01:59:41]

Committed patchset #6 (id:80002)

[commit-bot: I haz the power, 2015-10-05 02:00:35]

Patchset 6 (id:??) landed as
https://crrev.com/8b9d18cc05682b6e1a0faaa666a163f55f7a77d1
Cr-Commit-Position: refs/heads/master@{#352282}