Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1697)

Unified Diff: tools/android/memdump/memdump.cc

Issue 1369153002: Port most of the remainder of //tools/android from GYP to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/android/memdump/BUILD.gn ('k') | tools/android/ps_ext/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/android/memdump/memdump.cc
diff --git a/tools/android/memdump/memdump.cc b/tools/android/memdump/memdump.cc
index 2727157657023a5edd6fceca04ec0fa3a0dc7441..33539e96628bf9749ab12034871040f90be96c6c 100644
--- a/tools/android/memdump/memdump.cc
+++ b/tools/android/memdump/memdump.cc
@@ -216,7 +216,7 @@ bool GetPagesForMemoryMap(int pagemap_fd,
for (uint64 addr = memory_map.start_address, page_index = 0;
addr < memory_map.end_address;
addr += kPageSize, ++page_index) {
- DCHECK_EQ(0, addr % kPageSize);
+ DCHECK_EQ(0u, addr % kPageSize);
PageMapEntry page_map_entry = {};
static_assert(sizeof(PageMapEntry) == sizeof(uint64), "unexpected size");
ssize_t bytes = read(pagemap_fd, &page_map_entry, sizeof(page_map_entry));
« no previous file with comments | « tools/android/memdump/BUILD.gn ('k') | tools/android/ps_ext/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698