Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1368983002: [heap] No leakage of gc-idle-time-handler.h outside of heap. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] No leakage of gc-idle-time-handler.h outside of heap. This prevents the internal gc-idle-time-handler.h to be usable outisde of the "heap" directory. The logic inside that component is only useful within the GC and is now properly encapsulated. R=ulan@chromium.org Committed: https://crrev.com/ca5780690ddf3bd79723a2eb492e797fe64d5405 Cr-Commit-Position: refs/heads/master@{#30939}

Patch Set 1 #

Patch Set 2 : Drop obsolete forward declaration. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -62 lines) Patch
M src/heap/gc-idle-time-handler.h View 1 2 chunks +22 lines, -22 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/heap.h View 4 chunks +9 lines, -6 lines 0 comments Download
M src/heap/heap.cc View 9 chunks +15 lines, -9 lines 0 comments Download
M test/unittests/heap/gc-idle-time-handler-unittest.cc View 22 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-09-25 12:50:06 UTC) #1
ulan
lgtm!
5 years, 2 months ago (2015-09-25 12:52:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368983002/20001
5 years, 2 months ago (2015-09-25 12:59:12 UTC) #4
ulan
On 2015/09/25 12:52:56, ulan wrote: > lgtm! This is going to conflict with: https://codereview.chromium.org/1352453004/
5 years, 2 months ago (2015-09-25 13:03:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-25 13:55:16 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 13:55:39 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca5780690ddf3bd79723a2eb492e797fe64d5405
Cr-Commit-Position: refs/heads/master@{#30939}

Powered by Google App Engine
This is Rietveld 408576698