Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: src/heap/heap.h

Issue 1368983002: [heap] No leakage of gc-idle-time-handler.h outside of heap. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Drop obsolete forward declaration. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/gc-idle-time-handler.cc ('k') | src/heap/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index 3b6fd98da4f9cbe762c1754c2cdd0525e32065fe..6103641e0810019b8d8b4ca1d37349853cca98c4 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -12,7 +12,6 @@
#include "src/assert-scope.h"
#include "src/atomic-utils.h"
#include "src/globals.h"
-#include "src/heap/gc-idle-time-handler.h"
#include "src/heap/incremental-marking.h"
#include "src/heap/mark-compact.h"
#include "src/heap/spaces.h"
@@ -422,6 +421,10 @@ namespace internal {
// Forward declarations.
class ArrayBufferTracker;
+class GCIdleTimeAction;
+class GCIdleTimeHandler;
+class GCIdleTimeHeapState;
+class GCTracer;
class HeapObjectsFilter;
class HeapStats;
class Isolate;
@@ -1782,15 +1785,15 @@ class Heap {
double idle_time_in_ms, size_t size_of_objects,
size_t mark_compact_speed_in_bytes_per_ms);
- GCIdleTimeHandler::HeapState ComputeHeapState();
+ GCIdleTimeHeapState ComputeHeapState();
bool PerformIdleTimeAction(GCIdleTimeAction action,
- GCIdleTimeHandler::HeapState heap_state,
+ GCIdleTimeHeapState heap_state,
double deadline_in_ms);
void IdleNotificationEpilogue(GCIdleTimeAction action,
- GCIdleTimeHandler::HeapState heap_state,
- double start_ms, double deadline_in_ms);
+ GCIdleTimeHeapState heap_state, double start_ms,
+ double deadline_in_ms);
void CheckAndNotifyBackgroundIdleNotification(double idle_time_in_ms,
double now_ms);
@@ -2260,7 +2263,7 @@ class Heap {
IncrementalMarking incremental_marking_;
- GCIdleTimeHandler gc_idle_time_handler_;
+ GCIdleTimeHandler* gc_idle_time_handler_;
MemoryReducer* memory_reducer_;
« no previous file with comments | « src/heap/gc-idle-time-handler.cc ('k') | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698