chrome/browser/resources/settings/advanced_page/advanced_page.html - Issue 1368973003: Flesh out the location-page class to make it more general.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/advanced_page/advanced_page.html

Issue 1368973003: Flesh out the location-page class to make it more general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/location_page/location_page.html » ('j') | chrome/browser/resources/settings/location_page/location_page.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/advanced_page/advanced_page.html

diff --git a/chrome/browser/resources/settings/advanced_page/advanced_page.html b/chrome/browser/resources/settings/advanced_page/advanced_page.html

index eef34f13b861c65edc77e130e7271862ec1bc66b..96f259f93aa4e0933ff9e1726f9e5cc25510d8cb 100644

--- a/chrome/browser/resources/settings/advanced_page/advanced_page.html

+++ b/chrome/browser/resources/settings/advanced_page/advanced_page.html

@@ -22,7 +22,7 @@

</if>

<cr-settings-section route="location"

i18n-values="page-title:siteSettingsLocation">

- <cr-settings-location-page prefs="{{prefs}}">

+ <cr-settings-location-page prefs="{{prefs}}" contentSettingsType="[[5]]">

Dan Beam 2015/09/29 16:38:55 why are you binding something to the location page

Dan Beam 2015/09/29 16:38:55 i'm pretty sure this binds to this['5'] (which is

Finnur 2015/09/30 10:26:06 Because I envision this to be the page for all cat

</cr-settings-location-page>

</cr-settings-section>