Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: chrome/browser/resources/settings/advanced_page/advanced_page.html

Issue 1368973003: Flesh out the location-page class to make it more general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
2 <link rel="import" href="chrome://md-settings/a11y_page/a11y_page.html"> 2 <link rel="import" href="chrome://md-settings/a11y_page/a11y_page.html">
3 <link rel="import" href="chrome://md-settings/downloads_page/downloads_page.html "> 3 <link rel="import" href="chrome://md-settings/downloads_page/downloads_page.html ">
4 <link rel="import" href="chrome://md-settings/languages_page/languages_page.html "> 4 <link rel="import" href="chrome://md-settings/languages_page/languages_page.html ">
5 <link rel="import" href="chrome://md-settings/location_page/location_page.html"> 5 <link rel="import" href="chrome://md-settings/location_page/location_page.html">
6 <link rel="import" href="chrome://md-settings/privacy_page/privacy_page.html"> 6 <link rel="import" href="chrome://md-settings/privacy_page/privacy_page.html">
7 <link rel="import" href="chrome://md-settings/settings_page/settings_section.htm l"> 7 <link rel="import" href="chrome://md-settings/settings_page/settings_section.htm l">
8 <link rel="import" href="chrome://md-settings/sync_page/sync_page.html"> 8 <link rel="import" href="chrome://md-settings/sync_page/sync_page.html">
9 9
10 <if expr="chromeos"> 10 <if expr="chromeos">
11 <link rel="import" href="chrome://md-settings/date_time_page/date_time_page.html "> 11 <link rel="import" href="chrome://md-settings/date_time_page/date_time_page.html ">
12 </if> 12 </if>
13 13
14 <dom-module id="cr-settings-advanced-page"> 14 <dom-module id="cr-settings-advanced-page">
15 <template> 15 <template>
16 <if expr="chromeos"> 16 <if expr="chromeos">
17 <cr-settings-section route="dateTime" icon="device:access-time" 17 <cr-settings-section route="dateTime" icon="device:access-time"
18 i18n-values="page-title:dateTimePageTitle"> 18 i18n-values="page-title:dateTimePageTitle">
19 <cr-settings-date-time-page prefs="{{prefs}}"> 19 <cr-settings-date-time-page prefs="{{prefs}}">
20 </cr-settings-date-time-page> 20 </cr-settings-date-time-page>
21 </cr-settings-section> 21 </cr-settings-section>
22 </if> 22 </if>
23 <cr-settings-section route="location" 23 <cr-settings-section route="location"
24 i18n-values="page-title:siteSettingsLocation"> 24 i18n-values="page-title:siteSettingsLocation">
25 <cr-settings-location-page prefs="{{prefs}}"> 25 <cr-settings-location-page prefs="{{prefs}}" contentSettingsType="[[5]]">
Dan Beam 2015/09/29 16:38:55 why are you binding something to the location page
Dan Beam 2015/09/29 16:38:55 i'm pretty sure this binds to this['5'] (which is
Finnur 2015/09/30 10:26:06 Because I envision this to be the page for all cat
26 </cr-settings-location-page> 26 </cr-settings-location-page>
27 </cr-settings-section> 27 </cr-settings-section>
28 28
29 <cr-settings-section route="privacy" icon="lock" 29 <cr-settings-section route="privacy" icon="lock"
30 i18n-values="page-title:privacyPageTitle" 30 i18n-values="page-title:privacyPageTitle"
31 expand-container="{{expandContainer}}" 31 expand-container="{{expandContainer}}"
32 current-route="[[currentRoute]]" section="privacy"> 32 current-route="[[currentRoute]]" section="privacy">
33 <cr-settings-privacy-page prefs="{{prefs}}" 33 <cr-settings-privacy-page prefs="{{prefs}}"
34 current-route="{{currentRoute}}"> 34 current-route="{{currentRoute}}">
35 </cr-settings-privacy-page> 35 </cr-settings-privacy-page>
(...skipping 16 matching lines...) Expand all
52 <cr-settings-a11y-page prefs="{{prefs}}"></cr-settings-a11y-page> 52 <cr-settings-a11y-page prefs="{{prefs}}"></cr-settings-a11y-page>
53 </cr-settings-section> 53 </cr-settings-section>
54 54
55 <cr-settings-section route="sync" icon="notification:sync" 55 <cr-settings-section route="sync" icon="notification:sync"
56 i18n-values="page-title:syncPageTitle"> 56 i18n-values="page-title:syncPageTitle">
57 <cr-settings-sync-page></cr-settings-sync-page> 57 <cr-settings-sync-page></cr-settings-sync-page>
58 </cr-settings-section> 58 </cr-settings-section>
59 </template> 59 </template>
60 <script src="advanced_page.js"></script> 60 <script src="advanced_page.js"></script>
61 </dom-module> 61 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698