Introduce cr-settings-input and eliminate cr-input

chrome/browser/resources/settings/downloads_page/downloads_page.html

Index: chrome/browser/resources/settings/downloads_page/downloads_page.html
diff --git a/chrome/browser/resources/settings/downloads_page/downloads_page.html b/chrome/browser/resources/settings/downloads_page/downloads_page.html
index c26412447eae54474d76b9f62012880c3c844de5..cb8e9a099d66b4531d98976c62db38e231b03abd 100644
--- a/chrome/browser/resources/settings/downloads_page/downloads_page.html
+++ b/chrome/browser/resources/settings/downloads_page/downloads_page.html
@@ -1,9 +1,8 @@
 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-flex-layout.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input.html">
-<link rel="import" href="chrome://resources/cr_elements/v1_0/cr_input/cr_input.html">
 <link rel="import" href="chrome://md-settings/checkbox/checkbox.html">
+<link rel="import" href="chrome://md-settings/input/input.html">
 
 <dom-module id="cr-settings-downloads-page">
   <link rel="import" type="css"
@@ -13,10 +12,11 @@
     <div class="horizontal layout center">
       <div class="layout horizontal center">
         <div id="locationLabel" i18n-content="downloadLocation"></div>
-        <cr-input id="downloadsPath" floating-label="false"
-            value="{{prefs.download.default_directory.value}}"
-            readonly aria-labelledby="locationLabel">
-        </cr-input>
+        <cr-settings-input id="downloadsPath" readonly

[michaelpg, 2015/09/24 19:42:14]

readonly -> disabled?

[stevenjb, 2015/09/24 19:59:59]

I just moved this; I don't want to make any changes.

[michaelpg, 2015/09/24 20:03:54]

meh, a bug's a bug

[stevenjb, 2015/09/24 20:06:47]

Not really a bug though, it's a UX thing, right? I'm not familiar enough with
the design to make the call :P

[stevenjb, 2015/09/24 21:22:15]

So, readonly is valid, but we need to propagate it, and that is a bug, so I
fixed that.

I'll let whomever owns the page work with UX as to whether read-only or disabled
is more correct.

+            floating-label="false"

[michaelpg, 2015/09/24 19:42:14]

is floatingLabel a thing? (and if so shouldn't we remove the attribute entirely
to set it to "false", otherwise it's set to true by virtue of having a value)

[stevenjb, 2015/09/24 19:59:59]

floating-label does not appear to be a thing, I'll go ahead and remove that.

[stevenjb, 2015/09/24 21:22:15]

This is probably supposed to be no-label-float, so changed to that.

+            pref="{{prefs.download.default_directory}}"
+            aria-labelledby="locationLabel">
+        </cr-settings-input>
       </div>
       <paper-button id="changeDownloadsPath" on-tap="selectDownloadLocation_"
           i18n-content="changeDownloadLocation">