Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> | 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> |
| 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html"> | 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html"> |
| 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> | 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> |
| 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html"> | |
| 5 <link rel="import" href="chrome://resources/cr_elements/v1_0/cr_input/cr_input.h tml"> | |
| 6 <link rel="import" href="chrome://md-settings/checkbox/checkbox.html"> | 4 <link rel="import" href="chrome://md-settings/checkbox/checkbox.html"> |
| 5 <link rel="import" href="chrome://md-settings/input/input.html"> | |
| 7 | 6 |
| 8 <dom-module id="cr-settings-downloads-page"> | 7 <dom-module id="cr-settings-downloads-page"> |
| 9 <link rel="import" type="css" | 8 <link rel="import" type="css" |
| 10 href="chrome://md-settings/settings_page/settings_page.css"> | 9 href="chrome://md-settings/settings_page/settings_page.css"> |
| 11 <link rel="import" type="css" href="downloads_page.css"> | 10 <link rel="import" type="css" href="downloads_page.css"> |
| 12 <template> | 11 <template> |
| 13 <div class="horizontal layout center"> | 12 <div class="horizontal layout center"> |
| 14 <div class="layout horizontal center"> | 13 <div class="layout horizontal center"> |
| 15 <div id="locationLabel" i18n-content="downloadLocation"></div> | 14 <div id="locationLabel" i18n-content="downloadLocation"></div> |
| 16 <cr-input id="downloadsPath" floating-label="false" | 15 <cr-settings-input id="downloadsPath" readonly |
|
michaelpg
2015/09/24 19:42:14
readonly -> disabled?
stevenjb
2015/09/24 19:59:59
I just moved this; I don't want to make any change
michaelpg
2015/09/24 20:03:54
meh, a bug's a bug
stevenjb
2015/09/24 20:06:47
Not really a bug though, it's a UX thing, right? I
stevenjb
2015/09/24 21:22:15
So, readonly is valid, but we need to propagate it
| |
| 17 value="{{prefs.download.default_directory.value}}" | 16 floating-label="false" |
|
michaelpg
2015/09/24 19:42:14
is floatingLabel a thing? (and if so shouldn't we
stevenjb
2015/09/24 19:59:59
floating-label does not appear to be a thing, I'll
stevenjb
2015/09/24 21:22:15
This is probably supposed to be no-label-float, so
| |
| 18 readonly aria-labelledby="locationLabel"> | 17 pref="{{prefs.download.default_directory}}" |
| 19 </cr-input> | 18 aria-labelledby="locationLabel"> |
| 19 </cr-settings-input> | |
| 20 </div> | 20 </div> |
| 21 <paper-button id="changeDownloadsPath" on-tap="selectDownloadLocation_" | 21 <paper-button id="changeDownloadsPath" on-tap="selectDownloadLocation_" |
| 22 i18n-content="changeDownloadLocation"> | 22 i18n-content="changeDownloadLocation"> |
| 23 </paper-button> | 23 </paper-button> |
| 24 </div> | 24 </div> |
| 25 <cr-settings-checkbox pref="{{prefs.download.prompt_for_download}}" | 25 <cr-settings-checkbox pref="{{prefs.download.prompt_for_download}}" |
| 26 i18n-values="label:promptForDownload"> | 26 i18n-values="label:promptForDownload"> |
| 27 </cr-settings-checkbox> | 27 </cr-settings-checkbox> |
| 28 </template> | 28 </template> |
| 29 <script src="downloads_page.js"></script> | 29 <script src="downloads_page.js"></script> |
| 30 </dom-module> | 30 </dom-module> |
| OLD | NEW |