Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1368533003: [sql] Use memory-mapped I/O for sql::Connection. (Closed)

Created:
5 years, 3 months ago by Scott Hess - ex-Googler
Modified:
5 years, 2 months ago
Reviewers:
rmcilroy, pavely
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Use memory-mapped I/O for sql::Connection. sql::Connection::Open*() uses PRAGMA mmap_size to enable SQLite's memory-mapped I/O. Additionally instrument to flush dirty pages from the page cache after writes. [Relands https://crrev.com/9a1948a4d6d4, reverted at https://crrev.com/55c3216b15ce ] BUG=489784, 533682 Committed: https://crrev.com/5c2f4e50d96d8b2ae0ae4a5c7d319e6be3b33bca Cr-Commit-Position: refs/heads/master@{#351344}

Patch Set 1 #

Patch Set 2 : Disable mmap test under mojo. #

Patch Set 3 : Fix uninit vars in Connection. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -0 lines) Patch
M sql/connection.h View 3 chunks +20 lines, -0 lines 0 comments Download
M sql/connection.cc View 1 2 6 chunks +94 lines, -0 lines 0 comments Download
M sql/connection_unittest.cc View 1 2 chunks +80 lines, -0 lines 0 comments Download
M sql/statement.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M sync/syncable/directory_backing_store.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/sqlite/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
Scott Hess - ex-Googler
Disable mmap test under mojo.
5 years, 3 months ago (2015-09-24 03:12:02 UTC) #1
Scott Hess - ex-Googler
Fix uninit vars in Connection.
5 years, 3 months ago (2015-09-24 03:12:53 UTC) #2
Scott Hess - ex-Googler
https://codereview.chromium.org/1349863003/, slipstream https://codereview.chromium.org/1355403004/ to fix mojo test, slipstream https://codereview.chromium.org/1368493002/ to fix valgrind complaint.
5 years, 3 months ago (2015-09-24 03:13:32 UTC) #3
Scott Hess - ex-Googler
On 2015/09/24 03:13:32, Scott Hess wrote: > https://codereview.chromium.org/1349863003/, slipstream > https://codereview.chromium.org/1355403004/ to fix mojo test, ...
5 years, 3 months ago (2015-09-24 03:14:02 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368533003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368533003/40001
5 years, 3 months ago (2015-09-24 03:17:10 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-24 04:53:53 UTC) #8
Scott Hess - ex-Googler
https://codereview.chromium.org/1349863003/ got reverted, for one hard-to-predict reason (Mojo does some hackery WRT SQLite) and one ...
5 years, 2 months ago (2015-09-28 19:26:16 UTC) #10
rmcilroy
lgtm
5 years, 2 months ago (2015-09-28 19:53:46 UTC) #11
pavely
sync/* lgtm
5 years, 2 months ago (2015-09-28 20:40:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368533003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368533003/40001
5 years, 2 months ago (2015-09-29 16:04:34 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-29 17:21:31 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/5c2f4e50d96d8b2ae0ae4a5c7d319e6be3b33bca Cr-Commit-Position: refs/heads/master@{#351344}
5 years, 2 months ago (2015-09-29 17:22:18 UTC) #16
zhaoqin1
5 years, 2 months ago (2015-09-30 17:59:50 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1375583003/ by zhaoqin@chromium.org.

The reason for reverting is: data race reported by TSan on sql/connection.cc

BUG=537681.

Powered by Google App Engine
This is Rietveld 408576698