Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1365783002: Revert of [sql] Use memory-mapped I/O for sql::Connection. (Closed)

Created:
5 years, 3 months ago by jbroman
Modified:
5 years, 3 months ago
CC:
chromium-reviews, michaeln
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [sql] Use memory-mapped I/O for sql::Connection. (patchset #8 id:140001 of https://codereview.chromium.org/1349863003/ ) Reason for revert: mmap_enabled_ isn't initialized, causing MSAN failures: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_MSAN/5882/layout-test-results/virtual/sharedarraybuffer/fast/workers/constructor-proto-crash-log.txt STDERR: ==3138==WARNING: MemorySanitizer: use-of-uninitialized-value STDERR: #0 0x7fc8068d3a65 in ReleaseCacheMemoryIfNeeded sql/connection.cc:513:7 STDERR: #1 0x7fc8068d3a65 in sql::Connection::ExecuteAndReturnErrorCode(char const*) sql/connection.cc:943:0 STDERR: #2 0x7fc8068ca454 in sql::Connection::OpenInternal(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, sql::Connection::Retry) sql/connection.cc:1275:9 STDERR: #3 0x7fc8068c845f in sql::Connection::Open(base::FilePath const&) sql/connection.cc:367:10 STDERR: #4 0x7fc806b1b868 in storage::QuotaDatabase::LazyOpen(bool) storage/browser/quota/quota_database.cc:488:14 Original issue's description: > [sql] Use memory-mapped I/O for sql::Connection. > > sql::Connection::Open*() uses PRAGMA mmap_size to enable SQLite's > memory-mapped I/O. Additionally instrument to flush dirty pages from > the page cache after writes. > > BUG=489784, 533682 > > Committed: https://crrev.com/9a1948a4d6d445d5c8e209bdcd1cd050af72060b > Cr-Commit-Position: refs/heads/master@{#350362} R=shess@chromium.org TBR=pavely@chromium.org, pvalenzuela@chromium.org, rmcilroy@chromium.org, shess@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=489784, 533682 Committed: https://chromium.googlesource.com/chromium/src/+/55c3216b15cec4ae024d16960f01ca7d3874dd55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -211 lines) Patch
M sql/connection.h View 3 chunks +0 lines, -20 lines 0 comments Download
M sql/connection.cc View 5 chunks +0 lines, -91 lines 0 comments Download
M sql/connection_unittest.cc View 2 chunks +0 lines, -78 lines 0 comments Download
M sql/statement.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M sync/syncable/directory_backing_store.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/sqlite/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jbroman
Created Revert of [sql] Use memory-mapped I/O for sql::Connection.
5 years, 3 months ago (2015-09-23 22:37:40 UTC) #1
Scott Hess - ex-Googler
lgtm
5 years, 3 months ago (2015-09-23 22:40:25 UTC) #2
Scott Hess - ex-Googler
On 2015/09/23 22:40:25, Scott Hess wrote: > lgtm Misuru was asking about this - is ...
5 years, 3 months ago (2015-09-23 23:26:58 UTC) #5
jbroman
On 2015/09/23 at 22:40:25, shess wrote: > lgtm Not sure why the CQ has ignored ...
5 years, 3 months ago (2015-09-23 23:27:43 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/55c3216b15cec4ae024d16960f01ca7d3874dd55 Cr-Commit-Position: refs/heads/master@{#350386}
5 years, 3 months ago (2015-09-23 23:29:08 UTC) #7
jbroman
5 years, 3 months ago (2015-09-23 23:29:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
55c3216b15cec4ae024d16960f01ca7d3874dd55 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698