1. Delete prolog weak persistent handles when shutting down an isolate

runtime/vm/object.cc

Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc	(revision 31753)
+++ runtime/vm/object.cc	(working copy)
@@ -16467,7 +16467,7 @@
 
 FinalizablePersistentHandle* ExternalTypedData::AddFinalizer(
     void* peer, Dart_WeakPersistentHandleFinalizer callback) const {
-  SetPeer(peer);
+  Isolate::Current()->heap()->SetPeer(this->raw(), peer);

[Ivan Posva, 2014/01/14 02:08:28]

I don't think this is correct. Adding a VM internal finalizer should not have a
side-effect of setting the externally visible peer. For example the externally
visible peer for this type data could be some object that holds the data
internally.

[siva, 2014/01/14 16:44:14]

At least that is what the old code was doing. We seem to have a lot of
redundancy here, the peer is stored in multiple places.

On 2014/01/14 02:08:28, Ivan Posva wrote:

   return dart::AddFinalizer(*this, peer, callback);
 }