1. Delete prolog weak persistent handles when shutting down an isolate

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 16449 matching lines @@
 }
 
 
 void TypedData::PrintToJSONStream(JSONStream* stream, bool ref) const {
   Instance::PrintToJSONStream(stream, ref);
 }
 
 
 FinalizablePersistentHandle* ExternalTypedData::AddFinalizer(
     void* peer, Dart_WeakPersistentHandleFinalizer callback) const {
-  SetPeer(peer);
+  Isolate::Current()->heap()->SetPeer(this->raw(), peer);

[Ivan Posva, 2014/01/14 02:08:28]

I don't think this is correct. Adding a VM internal finalizer should not have a
side-effect of setting the externally visible peer. For example the externally
visible peer for this type data could be some object that holds the data
internally.

[siva, 2014/01/14 16:44:14]

At least that is what the old code was doing. We seem to have a lot of
redundancy here, the peer is stored in multiple places.

On 2014/01/14 02:08:28, Ivan Posva wrote:

   return dart::AddFinalizer(*this, peer, callback);
 }
 
 
 RawExternalTypedData* ExternalTypedData::New(intptr_t class_id,
                                              uint8_t* data,
                                              intptr_t len,
                                              Heap::Space space) {
   ExternalTypedData& result = ExternalTypedData::Handle();
   {
@@ skipping 493 matching lines @@
   return "_MirrorReference";
 }
 
 
 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const {
   Instance::PrintToJSONStream(stream, ref);
 }
 
 
 }  // namespace dart