Issue 1368513002: Merge to XFA: Allow external font-path configuration from pdfium_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1368513002: Merge to XFA: Allow external font-path configuration from pdfium_test. (Closed)

Created:
5 years, 3 months ago by Lei Zhang

Modified:
5 years, 3 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Allow external font-path configuration from pdfium_test. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1268323004 . (cherry picked from commit 9311163b564785a3a3ccdcb09bd3b7d0b2976d1a) Committed: https://pdfium.googlesource.com/pdfium/+/6f62d53b7650311afc490bfdaa48f5e8536b8b4e

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -29 lines)			Patch
M	core/include/fxge/fx_font.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/include/fxge/fx_ge.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	core/src/fxge/apple/fx_mac_imp.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/src/fxge/ge/fx_ge.cpp	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	core/src/fxge/ge/fx_ge_fontmap.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fxge/ge/fx_ge_linux.cpp	View	3 chunks	+13 lines, -9 lines	0 comments	Download
M	core/src/fxge/win32/fx_win32_device.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/fpdf_sysfontinfo.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/fpdfview.cpp	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	fpdfsdk/src/fpdfview_c_api_test.c	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	public/fpdfview.h	View	1 chunk	+25 lines, -1 line	0 comments	Download
M	samples/pdfium_test.cc	View	4 chunks	+22 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

TBR, trivial merge conflicts in core/src/fxge/ge/fx_ge.cpp and core/src/fxge/ge/fx_ge_linux.cpp, and git cl format changed its mind.

5 years, 3 months ago (2015-09-23 22:31:35 UTC) #1

Lei Zhang

5 years, 3 months ago (2015-09-23 22:31:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6f62d53b7650311afc490bfdaa48f5e8536b8b4e (presubmit successful).