Allow external font-path configuration from pdfium_test.

Allow external font-path configuration from pdfium_test.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/d8b5e73d8609b74e6a995ee1768d20d47bd4b089

Committed: https://pdfium.googlesource.com/pdfium/+/9311163b564785a3a3ccdcb09bd3b7d0b2976d1a

[Tom Sepez, 2015-08-06 21:57:01]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-08-06 21:57:01]

Lei, for review.

[Lei Zhang, 2015-08-06 22:28:36]

lgtm

https://codereview.chromium.org/1268323004/diff/1/core/include/fxge/fx_ge.h
File core/include/fxge/fx_ge.h (right):

https://codereview.chromium.org/1268323004/diff/1/core/include/fxge/fx_ge.h#n...
core/include/fxge/fx_ge.h:49: CFX_GEModule(const char** pUserFontPaths);
explicit

https://codereview.chromium.org/1268323004/diff/1/core/src/fxge/ge/fx_ge_linu...
File core/src/fxge/ge/fx_ge_linux.cpp (right):

https://codereview.chromium.org/1268323004/diff/1/core/src/fxge/ge/fx_ge_linu...
core/src/fxge/ge/fx_ge_linux.cpp:244: for (const char **pPath = pUserPaths;
*pPath; ++pPath) {
const char**

https://codereview.chromium.org/1268323004/diff/1/core/src/fxge/ge/fx_ge_linu...
core/src/fxge/ge/fx_ge_linux.cpp:250:
m_pFontMgr->SetSystemFontInfo(IFX_SystemFontInfo::CreateDefault(m_pUserFontPaths));
80 chars

https://codereview.chromium.org/1268323004/diff/1/public/fpdfview.h
File public/fpdfview.h (right):

https://codereview.chromium.org/1268323004/diff/1/public/fpdfview.h#newcode135
public/fpdfview.h:135: 
extra blank line

https://codereview.chromium.org/1268323004/diff/1/public/fpdfview.h#newcode139
public/fpdfview.h:139: // The Array may be NULL iself to use the default paths.
May be ignored
iself

https://codereview.chromium.org/1268323004/diff/1/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/1268323004/diff/1/samples/pdfium_test.cc#newc...
samples/pdfium_test.cc:351: } else if (cur_arg.size() > 11 && cur_arg.compare(0,
11, "--font-dir=") == 0) {
80 chars

[Tom Sepez, 2015-08-13 18:23:03]

Committed patchset #2 (id:20001) manually as
d8b5e73d8609b74e6a995ee1768d20d47bd4b089 (presubmit successful).

[Tom Sepez, 2015-08-13 18:29:58]

https://codereview.chromium.org/1268323004/diff/1/core/include/fxge/fx_ge.h
File core/include/fxge/fx_ge.h (right):

https://codereview.chromium.org/1268323004/diff/1/core/include/fxge/fx_ge.h#n...
core/include/fxge/fx_ge.h:49: CFX_GEModule(const char** pUserFontPaths);
On 2015/08/06 22:28:36, Lei Zhang wrote:
> explicit

Done.

https://codereview.chromium.org/1268323004/diff/1/core/src/fxge/ge/fx_ge_linu...
File core/src/fxge/ge/fx_ge_linux.cpp (right):

https://codereview.chromium.org/1268323004/diff/1/core/src/fxge/ge/fx_ge_linu...
core/src/fxge/ge/fx_ge_linux.cpp:244: for (const char **pPath = pUserPaths;
*pPath; ++pPath) {
On 2015/08/06 22:28:36, Lei Zhang wrote:
> const char**

Done.

https://codereview.chromium.org/1268323004/diff/1/core/src/fxge/ge/fx_ge_linu...
core/src/fxge/ge/fx_ge_linux.cpp:250:
m_pFontMgr->SetSystemFontInfo(IFX_SystemFontInfo::CreateDefault(m_pUserFontPaths));
On 2015/08/06 22:28:36, Lei Zhang wrote:
> 80 chars

Done.

https://codereview.chromium.org/1268323004/diff/1/public/fpdfview.h
File public/fpdfview.h (right):

https://codereview.chromium.org/1268323004/diff/1/public/fpdfview.h#newcode135
public/fpdfview.h:135: 
On 2015/08/06 22:28:36, Lei Zhang wrote:
> extra blank line

Done.

https://codereview.chromium.org/1268323004/diff/1/public/fpdfview.h#newcode139
public/fpdfview.h:139: // The Array may be NULL iself to use the default paths.
May be ignored
On 2015/08/06 22:28:36, Lei Zhang wrote:
> iself

Done.

https://codereview.chromium.org/1268323004/diff/1/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/1268323004/diff/1/samples/pdfium_test.cc#newc...
samples/pdfium_test.cc:351: } else if (cur_arg.size() > 11 && cur_arg.compare(0,
11, "--font-dir=") == 0) {
On 2015/08/06 22:28:36, Lei Zhang wrote:
> 80 chars

Done.

[Tom Sepez, 2015-08-13 18:47:20]

re-opened.  I meant to land everything up to the part where the flag is added to
run_corpus_tests.py

[Tom Sepez, 2015-08-13 18:52:50]

Committed patchset #3 (id:40001) manually as
9311163b564785a3a3ccdcb09bd3b7d0b2976d1a (presubmit successful).

[Nico, 2015-08-13 22:02:05]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-08-13 22:02:06]

https://codereview.chromium.org/1268323004/diff/40001/fpdfsdk/src/fpdfview.cpp
File fpdfsdk/src/fpdfview.cpp (right):

https://codereview.chromium.org/1268323004/diff/40001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:98: const FPDF_LIBRARY_CONFIG* cfg) {
This too isn't clang-formatted. How do you upload and commit your stuff? Do you
use `git cl land`? The presubmit works for me locally.

[Nico, 2015-08-13 22:10:08]

On 2015/08/13 22:02:06, Nico (hiding) wrote:
> https://codereview.chromium.org/1268323004/diff/40001/fpdfsdk/src/fpdfview.cpp
> File fpdfsdk/src/fpdfview.cpp (right):
> 
>
https://codereview.chromium.org/1268323004/diff/40001/fpdfsdk/src/fpdfview.cp...
> fpdfsdk/src/fpdfview.cpp:98: const FPDF_LIBRARY_CONFIG* cfg) {
> This too isn't clang-formatted. How do you upload and commit your stuff? Do
you
> use `git cl land`? The presubmit works for me locally.

buildtools isn't for clang; it's where gn is mostly (and clang-format. But not
clang.). If pdfium standalone doesn't pull buildtools, it probably should. It's
pretty small, easy to add to DEPS, and at some point it'll be required for gn
anyhoo.

[Lei Zhang, 2015-08-13 22:11:05]

On 2015/08/13 22:10:08, Nico (hiding) wrote:
> On 2015/08/13 22:02:06, Nico (hiding) wrote:
> >
https://codereview.chromium.org/1268323004/diff/40001/fpdfsdk/src/fpdfview.cpp
> > File fpdfsdk/src/fpdfview.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1268323004/diff/40001/fpdfsdk/src/fpdfview.cp...
> > fpdfsdk/src/fpdfview.cpp:98: const FPDF_LIBRARY_CONFIG* cfg) {
> > This too isn't clang-formatted. How do you upload and commit your stuff? Do
> you
> > use `git cl land`? The presubmit works for me locally.
> 
> buildtools isn't for clang; it's where gn is mostly (and clang-format. But not
> clang.). If pdfium standalone doesn't pull buildtools, it probably should.
It's
> pretty small, easy to add to DEPS, and at some point it'll be required for gn
> anyhoo.

It's already in DEPS. Maybe tsepez's repo hasn't been gclient sync'd in a while?