Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 13685015: disable CommitWhenShownInFullHeightWithoutFocus on Mac (Closed)

Created:
7 years, 8 months ago by scottmg
Modified:
7 years, 8 months ago
Reviewers:
xhwang
CC:
chromium-reviews, melevin, dhollowa+watch_chromium.org, dougw+watch_chromium.org, sreeram, gideonwald, dominich, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

disable CommitWhenShownInFullHeightWithoutFocus on Mac Timing out on regular and ASAN bots. Note: Google Test filter = InstantExtendedTest.CommitWhenShownInFullHeightWithoutFocus [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from InstantExtendedTest, where TypeParam = [ RUN ] InstantExtendedTest.CommitWhenShownInFullHeightWithoutFocus Right after fork Right before base::type_profiler::Controller::Stop() Right after base::type_profiler::Controller::Stop() Right after signal/exception handler restoration. Right after fd_shuffle push_backs. Right after ShuffleFileDescriptors Right after CloseSuperfluousFds Right before execvp /Volumes/data/b/build/third_party/zope/__init__.py:19: UserWarning: Module twisted was already imported from /Volumes/data/b/build/third_party/twisted_10_2/twisted/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path import pkg_resources /Volumes/data/b/build/third_party/zope/__init__.py:19: UserWarning: Module zope was already imported from /Volumes/data/b/build/third_party/zope/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path import pkg_resources HTTPS server started on 127.0.0.1:50602... sending server_data: {"host": "127.0.0.1", "port": 50602} (36 bytes) [0405/102718:ERROR:test_launcher.cc(365)] Test timeout (60000 ms) exceeded for InstantExtendedTest.CommitWhenShownInFullHeightWithoutFocus BrowserTestBase signal handler received SIGTERM. Backtrace: 0 interactive_ui_tests 0x03a4fe9a base::debug::StackTrace::StackTrace() + 26 1 interactive_ui_tests 0x03640083 (anonymous namespace)::DumpStackTraceSignalHandler(int) + 131 2 libSystem.B.dylib 0x951de05b _sigtramp + 43 3 ??? 0xffffffff 0x0 + 4294967295 4 CoreFoundation 0x97a702df __CFRunLoopRun + 2079 5 CoreFoundation 0x97a6f3c4 CFRunLoopRunSpecific + 452 6 CoreFoundation 0x97a6f1f1 CFRunLoopRunInMode + 97 7 HIToolbox 0x91cd1e04 RunCurrentEventLoopInMode + 392 8 HIToolbox 0x91cd1bb9 ReceiveNextEventCommon + 354 9 HIToolbox 0x91cd1a3e BlockUntilNextEventMatchingListInMode + 81 10 AppKit 0x980f2595 _DPSNextEvent + 847 11 AppKit 0x980f1dd6 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 156 12 AppKit 0x980b41f3 -[NSApplication run] + 821 13 interactive_ui_tests 0x03a14a51 base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 737 14 interactive_ui_tests 0x03a136b0 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 448 15 interactive_ui_tests 0x03ac44fa base::MessageLoop::RunInternal() + 650 16 interactive_ui_tests 0x03b1efd5 base::RunLoop::Run() + 69 17 interactive_ui_tests 0x0365be40 content::RunThisRunLoop(base::RunLoop*) + 144 18 interactive_ui_tests 0x0365d343 content::WindowedNotificationObserver::Wait() + 611 19 interactive_ui_tests 0x008f7749 InstantExtendedTest_CommitWhenShownInFullHeightWithoutFocus_Test::RunTestOnMainThread() + 12777 20 interactive_ui_tests 0x0a6af765 InProcessBrowserTest::RunTestOnMainThreadLoop() + 581 21 interactive_ui_tests 0x036405b9 base::internal::Invoker<1, base::internal::BindState<base::internal::RunnableAdapter<void (content::BrowserTestBase::*)()>, void ()(content::BrowserTestBase*), void ()(content::BrowserTestBase*)>, void ()(content::BrowserTestBase*)>::Run(base::internal::BindStateBase*) + 137 22 interactive_ui_tests 0x05fd844c ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 23292 23 interactive_ui_tests 0x05fd27cc ChromeBrowserMainParts::PreMainMessageLoopRun() + 28 24 interactive_ui_tests 0x05677805 content::BrowserMainLoop::CreateThreads() + 1813 25 interactive_ui_tests 0x0567b058 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 1080 26 interactive_ui_tests 0x0567441e content::BrowserMain(content::MainFunctionParams const&) + 142 27 interactive_ui_tests 0x0363fd44 content::BrowserTestBase::SetUp() + 1076 28 interactive_ui_tests 0x0a6abdc7 InProcessBrowserTest::SetUp() + 1943 29 interactive_ui_tests 0x0260b299 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 473 30 interactive_ui_tests 0x025f0910 testing::Test::Run() + 752 31 interactive_ui_tests 0x025f22d1 testing::TestInfo::Run() + 1601 32 interactive_ui_tests 0x025f31ea testing::TestCase::Run() + 1418 33 interactive_ui_tests 0x02604d83 testing::internal::UnitTestImpl::RunAllTests() + 3043 34 interactive_ui_tests 0x0260cbd9 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 473 35 interactive_ui_tests 0x02604133 testing::UnitTest::Run() + 307 36 interactive_ui_tests 0x04e0bb51 base::TestSuite::Run() + 673 37 interactive_ui_tests 0x00985d94 ChromeTestLauncherDelegate::RunTestSuite(int, char**) + 132 38 interactive_ui_tests 0x0365277c content::LaunchTests(content::TestLauncherDelegate*, int, char**) + 3884 39 interactive_ui_tests 0x00985b8c main + 172 40 interactive_ui_tests 0x000030a5 start + 53 R=xhwang@chromium.org BUG=227076 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192602

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/ui/search/instant_extended_browsertest.cc View 1 1 chunk +10 lines, -1 line 3 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
7 years, 8 months ago (2013-04-05 17:57:10 UTC) #1
xhwang
https://codereview.chromium.org/13685015/diff/2001/chrome/browser/ui/search/instant_extended_browsertest.cc File chrome/browser/ui/search/instant_extended_browsertest.cc (right): https://codereview.chromium.org/13685015/diff/2001/chrome/browser/ui/search/instant_extended_browsertest.cc#newcode1147 chrome/browser/ui/search/instant_extended_browsertest.cc:1147: CommitWhenShownInFullHeightWithoutFocus) { Add MAYBE_?
7 years, 8 months ago (2013-04-05 18:01:25 UTC) #2
scottmg
On 2013/04/05 18:01:25, xhwang wrote: > https://codereview.chromium.org/13685015/diff/2001/chrome/browser/ui/search/instant_extended_browsertest.cc > File chrome/browser/ui/search/instant_extended_browsertest.cc (right): > > https://codereview.chromium.org/13685015/diff/2001/chrome/browser/ui/search/instant_extended_browsertest.cc#newcode1147 > ...
7 years, 8 months ago (2013-04-05 18:02:27 UTC) #3
xhwang
lgtm % nit https://codereview.chromium.org/13685015/diff/6001/chrome/browser/ui/search/instant_extended_browsertest.cc File chrome/browser/ui/search/instant_extended_browsertest.cc (right): https://codereview.chromium.org/13685015/diff/6001/chrome/browser/ui/search/instant_extended_browsertest.cc#newcode1138 chrome/browser/ui/search/instant_extended_browsertest.cc:1138: DISABLED_CommitWhenShownInFullHeightWithoutFocus nit: should it be 4-space ...
7 years, 8 months ago (2013-04-05 18:07:32 UTC) #4
scottmg
https://codereview.chromium.org/13685015/diff/6001/chrome/browser/ui/search/instant_extended_browsertest.cc File chrome/browser/ui/search/instant_extended_browsertest.cc (right): https://codereview.chromium.org/13685015/diff/6001/chrome/browser/ui/search/instant_extended_browsertest.cc#newcode1138 chrome/browser/ui/search/instant_extended_browsertest.cc:1138: DISABLED_CommitWhenShownInFullHeightWithoutFocus On 2013/04/05 18:07:32, xhwang wrote: > nit: should ...
7 years, 8 months ago (2013-04-05 18:08:41 UTC) #5
scottmg
Committed patchset #2 manually as r192602.
7 years, 8 months ago (2013-04-05 18:09:05 UTC) #6
xhwang
7 years, 8 months ago (2013-04-05 18:25:07 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/13685015/diff/6001/chrome/browser/ui/search/i...
File chrome/browser/ui/search/instant_extended_browsertest.cc (right):

https://codereview.chromium.org/13685015/diff/6001/chrome/browser/ui/search/i...
chrome/browser/ui/search/instant_extended_browsertest.cc:1138:
DISABLED_CommitWhenShownInFullHeightWithoutFocus
On 2013/04/05 18:08:42, scottmg wrote:
> On 2013/04/05 18:07:32, xhwang wrote:
> > nit: should it be 4-space indent here and below?
> 
> ah, i was copying the one above. i can change it if you like.

sg, consistency overrules other rules :)

Powered by Google App Engine
This is Rietveld 408576698