Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: chrome/browser/ui/search/instant_extended_browsertest.cc

Issue 13685015: disable CommitWhenShownInFullHeightWithoutFocus on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/instant_extended_browsertest.cc
diff --git a/chrome/browser/ui/search/instant_extended_browsertest.cc b/chrome/browser/ui/search/instant_extended_browsertest.cc
index 3bfeb77f672bc69d825a0f9a724e7d26d86aef8e..819123bb6aa092d90f06f1dcb3a6329203c3a95d 100644
--- a/chrome/browser/ui/search/instant_extended_browsertest.cc
+++ b/chrome/browser/ui/search/instant_extended_browsertest.cc
@@ -1132,10 +1132,19 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedTest,
EXPECT_EQ(overlay, active_tab);
}
+#if defined(OS_MACOSX)
+// http://crbug.com/227076
+#define MAYBE_CommitWhenShownInFullHeightWithoutFocus \
+ DISABLED_CommitWhenShownInFullHeightWithoutFocus
xhwang 2013/04/05 18:07:32 nit: should it be 4-space indent here and below?
scottmg 2013/04/05 18:08:42 ah, i was copying the one above. i can change it i
xhwang 2013/04/05 18:25:07 sg, consistency overrules other rules :)
+#else
+#define MAYBE_CommitWhenShownInFullHeightWithoutFocus \
+ CommitWhenShownInFullHeightWithoutFocus
+#endif
+
// Test that the overlay is committed when shown at 100% height without focus
// in the omnibox.
IN_PROC_BROWSER_TEST_F(InstantExtendedTest,
- CommitWhenShownInFullHeightWithoutFocus) {
+ MAYBE_CommitWhenShownInFullHeightWithoutFocus) {
ASSERT_NO_FATAL_FAILURE(SetupInstant(browser()));
// Focus omnibox and confirm overlay isn't shown.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698