Use child processors to implement compose color filter.

Use child processors to implement compose color filter.

Committed: https://skia.googlesource.com/skia/+/e25eea4b36a488448fb730f4e3dc5a900b0e2892

[bsalomon, 2015-09-28 20:59:18]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, joshualitt@google.com

[egdaniel, 2015-09-29 13:23:52]

lgtm with nits

https://codereview.chromium.org/1368423003/diff/40001/src/gpu/GrFragmentProce...
File src/gpu/GrFragmentProcessor.cpp (right):

https://codereview.chromium.org/1368423003/diff/40001/src/gpu/GrFragmentProce...
src/gpu/GrFragmentProcessor.cpp:283: #include "effects/GrConstColorProcessor.h"
Do we want this include in middle of file? Usually I've only seen us do this if
we are in the middle of an Sk file.

https://codereview.chromium.org/1368423003/diff/40001/src/gpu/SkGr.cpp
File src/gpu/SkGr.cpp (right):

https://codereview.chromium.org/1368423003/diff/40001/src/gpu/SkGr.cpp#newcod...
src/gpu/SkGr.cpp:816: grPaint->getProcessorDataManager()));
Is there any cleaner way to alight this so that it's obvious the second param is
part of asFragProc(...)

https://codereview.chromium.org/1368423003/diff/40001/tests/GpuColorFilterTes...
File tests/GpuColorFilterTest.cpp (right):

https://codereview.chromium.org/1368423003/diff/40001/tests/GpuColorFilterTes...
tests/GpuColorFilterTest.cpp:104: SkAutoTUnref<const GrFragmentProcessor>
fp(cf->asFragmentProcessor(grContext, paint.getProcessorDataManager()));
100 chars

[bsalomon, 2015-09-29 13:31:43]

https://codereview.chromium.org/1368423003/diff/40001/src/gpu/GrFragmentProce...
File src/gpu/GrFragmentProcessor.cpp (right):

https://codereview.chromium.org/1368423003/diff/40001/src/gpu/GrFragmentProce...
src/gpu/GrFragmentProcessor.cpp:283: #include "effects/GrConstColorProcessor.h"
On 2015/09/29 13:23:52, egdaniel wrote:
> Do we want this include in middle of file? Usually I've only seen us do this
if
> we are in the middle of an Sk file.

Done.

https://codereview.chromium.org/1368423003/diff/40001/src/gpu/SkGr.cpp
File src/gpu/SkGr.cpp (right):

https://codereview.chromium.org/1368423003/diff/40001/src/gpu/SkGr.cpp#newcod...
src/gpu/SkGr.cpp:816: grPaint->getProcessorDataManager()));
On 2015/09/29 13:23:52, egdaniel wrote:
> Is there any cleaner way to alight this so that it's obvious the second param
is
> part of asFragProc(...)

Done.

https://codereview.chromium.org/1368423003/diff/40001/tests/GpuColorFilterTes...
File tests/GpuColorFilterTest.cpp (right):

https://codereview.chromium.org/1368423003/diff/40001/tests/GpuColorFilterTes...
tests/GpuColorFilterTest.cpp:104: SkAutoTUnref<const GrFragmentProcessor>
fp(cf->asFragmentProcessor(grContext, paint.getProcessorDataManager()));
On 2015/09/29 13:23:52, egdaniel wrote:
> 100 chars

"Fixed" along with surrounding code.

[bsalomon, 2015-09-29 13:31:56]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-09-29 13:31:57]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1368423003/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2015-09-29 13:32:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1368423003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1368423003/60001

[commit-bot: I haz the power, 2015-09-29 13:38:59]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/e25eea4b36a488448fb730f4e3dc5a900b0e2892