Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1467)

Unified Diff: chrome/browser/ui/views/frame/browser_view_browsertest.cc

Issue 13684002: cros: Instant extended support for immersive fullscreen (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: method ordering Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view_browsertest.cc
diff --git a/chrome/browser/ui/views/frame/browser_view_browsertest.cc b/chrome/browser/ui/views/frame/browser_view_browsertest.cc
index 8a384a08b748b566604cc19999dbff109b29f83b..693f65b520eb8ea1beab7862bff7b451d24b752f 100644
--- a/chrome/browser/ui/views/frame/browser_view_browsertest.cc
+++ b/chrome/browser/ui/views/frame/browser_view_browsertest.cc
@@ -7,6 +7,7 @@
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"
+#include "chrome/browser/ui/views/frame/browser_view_layout.h"
#include "chrome/browser/ui/views/frame/top_container_view.h"
#include "chrome/browser/ui/views/infobars/infobar_container_view.h"
#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
@@ -15,7 +16,10 @@
#include "chrome/common/url_constants.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
+#include "ui/views/controls/single_split_view.h"
+#include "ui/views/controls/webview/webview.h"
#include "ui/views/focus/focus_manager.h"
+#include "ui/views/window/non_client_view.h"
using views::FocusManager;
@@ -26,6 +30,12 @@ IN_PROC_BROWSER_TEST_F(BrowserViewTest, BrowserView) {
BrowserView* browser_view = static_cast<BrowserView*>(browser()->window());
TopContainerView* top_container = browser_view->top_container();
+ TabStrip* tabstrip = browser_view->tabstrip();
+ ToolbarView* toolbar = browser_view->toolbar();
+ views::SingleSplitView* contents_split =
+ browser_view->GetContentsSplitForTest();
+ views::WebView* contents_container =
+ browser_view->GetContentsContainerForTest();
// Verify the view hierarchy.
EXPECT_EQ(top_container, browser_view->tabstrip()->parent());
@@ -41,6 +51,17 @@ IN_PROC_BROWSER_TEST_F(BrowserViewTest, BrowserView) {
EXPECT_EQ(0, top_container->x());
EXPECT_EQ(0, top_container->y());
EXPECT_EQ(browser_view->width(), top_container->width());
+ EXPECT_EQ(0, tabstrip->x());
+ EXPECT_EQ(0, tabstrip->y());
+ EXPECT_EQ(0, toolbar->x());
+ EXPECT_EQ(
+ tabstrip->height() -
+ BrowserViewLayout::kToolbarTabStripVerticalOverlap,
+ toolbar->y());
+ EXPECT_EQ(0, contents_split->x());
+ EXPECT_EQ(toolbar->bounds().bottom(), contents_split->y());
+ EXPECT_EQ(0, contents_container->x());
+ EXPECT_EQ(0, contents_container->y());
// Verify bookmark bar visibility.
BookmarkBarView* bookmark_bar = browser_view->GetBookmarkBarView();
@@ -59,6 +80,20 @@ IN_PROC_BROWSER_TEST_F(BrowserViewTest, BrowserView) {
EXPECT_TRUE(bookmark_bar->IsDetached());
EXPECT_EQ(browser_view, bookmark_bar->parent());
+ // Bookmark bar layout on NTP.
+ EXPECT_EQ(0, bookmark_bar->x());
+ EXPECT_EQ(
+ tabstrip->height() +
+ toolbar->height() -
+ BrowserViewLayout::kToolbarTabStripVerticalOverlap -
+ views::NonClientFrameView::kClientEdgeThickness,
+ bookmark_bar->y());
+ EXPECT_EQ(toolbar->bounds().bottom(), contents_split->y());
+ // Contents have a "top margin" pushing them below the bookmark bar.
+ EXPECT_EQ(bookmark_bar->height() -
+ views::NonClientFrameView::kClientEdgeThickness,
+ contents_container->y());
+
// Bookmark bar is parented back to top container on normal page.
ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
EXPECT_FALSE(bookmark_bar->visible());

Powered by Google App Engine
This is Rietveld 408576698