| OLD | NEW |
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "chrome/browser/ui/views/frame/browser_view.h" | 5 #include "chrome/browser/ui/views/frame/browser_view.h" |
| 6 | 6 |
| 7 #include "chrome/app/chrome_command_ids.h" | 7 #include "chrome/app/chrome_command_ids.h" |
| 8 #include "chrome/browser/ui/browser_commands.h" | 8 #include "chrome/browser/ui/browser_commands.h" |
| 9 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h" | 9 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h" |
| 10 #include "chrome/browser/ui/views/frame/browser_view_layout.h" |
| 10 #include "chrome/browser/ui/views/frame/top_container_view.h" | 11 #include "chrome/browser/ui/views/frame/top_container_view.h" |
| 11 #include "chrome/browser/ui/views/infobars/infobar_container_view.h" | 12 #include "chrome/browser/ui/views/infobars/infobar_container_view.h" |
| 12 #include "chrome/browser/ui/views/location_bar/location_bar_view.h" | 13 #include "chrome/browser/ui/views/location_bar/location_bar_view.h" |
| 13 #include "chrome/browser/ui/views/tabs/tab_strip.h" | 14 #include "chrome/browser/ui/views/tabs/tab_strip.h" |
| 14 #include "chrome/browser/ui/views/toolbar_view.h" | 15 #include "chrome/browser/ui/views/toolbar_view.h" |
| 15 #include "chrome/common/url_constants.h" | 16 #include "chrome/common/url_constants.h" |
| 16 #include "chrome/test/base/in_process_browser_test.h" | 17 #include "chrome/test/base/in_process_browser_test.h" |
| 17 #include "chrome/test/base/ui_test_utils.h" | 18 #include "chrome/test/base/ui_test_utils.h" |
| 19 #include "ui/views/controls/single_split_view.h" |
| 20 #include "ui/views/controls/webview/webview.h" |
| 18 #include "ui/views/focus/focus_manager.h" | 21 #include "ui/views/focus/focus_manager.h" |
| 22 #include "ui/views/window/non_client_view.h" |
| 19 | 23 |
| 20 using views::FocusManager; | 24 using views::FocusManager; |
| 21 | 25 |
| 22 typedef InProcessBrowserTest BrowserViewTest; | 26 typedef InProcessBrowserTest BrowserViewTest; |
| 23 | 27 |
| 24 IN_PROC_BROWSER_TEST_F(BrowserViewTest, BrowserView) { | 28 IN_PROC_BROWSER_TEST_F(BrowserViewTest, BrowserView) { |
| 25 BookmarkBarView::DisableAnimationsForTesting(true); | 29 BookmarkBarView::DisableAnimationsForTesting(true); |
| 26 | 30 |
| 27 BrowserView* browser_view = static_cast<BrowserView*>(browser()->window()); | 31 BrowserView* browser_view = static_cast<BrowserView*>(browser()->window()); |
| 28 TopContainerView* top_container = browser_view->top_container(); | 32 TopContainerView* top_container = browser_view->top_container(); |
| 33 TabStrip* tabstrip = browser_view->tabstrip(); |
| 34 ToolbarView* toolbar = browser_view->toolbar(); |
| 35 views::SingleSplitView* contents_split = |
| 36 browser_view->GetContentsSplitForTest(); |
| 37 views::WebView* contents_container = |
| 38 browser_view->GetContentsContainerForTest(); |
| 29 | 39 |
| 30 // Verify the view hierarchy. | 40 // Verify the view hierarchy. |
| 31 EXPECT_EQ(top_container, browser_view->tabstrip()->parent()); | 41 EXPECT_EQ(top_container, browser_view->tabstrip()->parent()); |
| 32 EXPECT_EQ(top_container, browser_view->toolbar()->parent()); | 42 EXPECT_EQ(top_container, browser_view->toolbar()->parent()); |
| 33 EXPECT_EQ(top_container, browser_view->GetBookmarkBarView()->parent()); | 43 EXPECT_EQ(top_container, browser_view->GetBookmarkBarView()->parent()); |
| 34 EXPECT_EQ(browser_view, browser_view->infobar_container()->parent()); | 44 EXPECT_EQ(browser_view, browser_view->infobar_container()->parent()); |
| 35 | 45 |
| 36 // Top container is at the front of the view hierarchy. | 46 // Top container is at the front of the view hierarchy. |
| 37 EXPECT_EQ(browser_view->child_count() - 1, | 47 EXPECT_EQ(browser_view->child_count() - 1, |
| 38 browser_view->GetIndexOf(top_container)); | 48 browser_view->GetIndexOf(top_container)); |
| 39 | 49 |
| 40 // Verify basic layout. | 50 // Verify basic layout. |
| 41 EXPECT_EQ(0, top_container->x()); | 51 EXPECT_EQ(0, top_container->x()); |
| 42 EXPECT_EQ(0, top_container->y()); | 52 EXPECT_EQ(0, top_container->y()); |
| 43 EXPECT_EQ(browser_view->width(), top_container->width()); | 53 EXPECT_EQ(browser_view->width(), top_container->width()); |
| 54 EXPECT_EQ(0, tabstrip->x()); |
| 55 EXPECT_EQ(0, tabstrip->y()); |
| 56 EXPECT_EQ(0, toolbar->x()); |
| 57 EXPECT_EQ( |
| 58 tabstrip->height() - |
| 59 BrowserViewLayout::kToolbarTabStripVerticalOverlap, |
| 60 toolbar->y()); |
| 61 EXPECT_EQ(0, contents_split->x()); |
| 62 EXPECT_EQ(toolbar->bounds().bottom(), contents_split->y()); |
| 63 EXPECT_EQ(0, contents_container->x()); |
| 64 EXPECT_EQ(0, contents_container->y()); |
| 44 | 65 |
| 45 // Verify bookmark bar visibility. | 66 // Verify bookmark bar visibility. |
| 46 BookmarkBarView* bookmark_bar = browser_view->GetBookmarkBarView(); | 67 BookmarkBarView* bookmark_bar = browser_view->GetBookmarkBarView(); |
| 47 EXPECT_FALSE(bookmark_bar->visible()); | 68 EXPECT_FALSE(bookmark_bar->visible()); |
| 48 EXPECT_FALSE(bookmark_bar->IsDetached()); | 69 EXPECT_FALSE(bookmark_bar->IsDetached()); |
| 49 chrome::ExecuteCommand(browser(), IDC_SHOW_BOOKMARK_BAR); | 70 chrome::ExecuteCommand(browser(), IDC_SHOW_BOOKMARK_BAR); |
| 50 EXPECT_TRUE(bookmark_bar->visible()); | 71 EXPECT_TRUE(bookmark_bar->visible()); |
| 51 EXPECT_FALSE(bookmark_bar->IsDetached()); | 72 EXPECT_FALSE(bookmark_bar->IsDetached()); |
| 52 chrome::ExecuteCommand(browser(), IDC_SHOW_BOOKMARK_BAR); | 73 chrome::ExecuteCommand(browser(), IDC_SHOW_BOOKMARK_BAR); |
| 53 EXPECT_FALSE(bookmark_bar->visible()); | 74 EXPECT_FALSE(bookmark_bar->visible()); |
| 54 EXPECT_FALSE(bookmark_bar->IsDetached()); | 75 EXPECT_FALSE(bookmark_bar->IsDetached()); |
| 55 | 76 |
| 56 // Bookmark bar is reparented to BrowserView on NTP. | 77 // Bookmark bar is reparented to BrowserView on NTP. |
| 57 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUINewTabURL)); | 78 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUINewTabURL)); |
| 58 EXPECT_TRUE(bookmark_bar->visible()); | 79 EXPECT_TRUE(bookmark_bar->visible()); |
| 59 EXPECT_TRUE(bookmark_bar->IsDetached()); | 80 EXPECT_TRUE(bookmark_bar->IsDetached()); |
| 60 EXPECT_EQ(browser_view, bookmark_bar->parent()); | 81 EXPECT_EQ(browser_view, bookmark_bar->parent()); |
| 61 | 82 |
| 83 // Bookmark bar layout on NTP. |
| 84 EXPECT_EQ(0, bookmark_bar->x()); |
| 85 EXPECT_EQ( |
| 86 tabstrip->height() + |
| 87 toolbar->height() - |
| 88 BrowserViewLayout::kToolbarTabStripVerticalOverlap - |
| 89 views::NonClientFrameView::kClientEdgeThickness, |
| 90 bookmark_bar->y()); |
| 91 EXPECT_EQ(toolbar->bounds().bottom(), contents_split->y()); |
| 92 // Contents have a "top margin" pushing them below the bookmark bar. |
| 93 EXPECT_EQ(bookmark_bar->height() - |
| 94 views::NonClientFrameView::kClientEdgeThickness, |
| 95 contents_container->y()); |
| 96 |
| 62 // Bookmark bar is parented back to top container on normal page. | 97 // Bookmark bar is parented back to top container on normal page. |
| 63 ui_test_utils::NavigateToURL(browser(), GURL("about:blank")); | 98 ui_test_utils::NavigateToURL(browser(), GURL("about:blank")); |
| 64 EXPECT_FALSE(bookmark_bar->visible()); | 99 EXPECT_FALSE(bookmark_bar->visible()); |
| 65 EXPECT_FALSE(bookmark_bar->IsDetached()); | 100 EXPECT_FALSE(bookmark_bar->IsDetached()); |
| 66 EXPECT_EQ(top_container, bookmark_bar->parent()); | 101 EXPECT_EQ(top_container, bookmark_bar->parent()); |
| 67 | 102 |
| 68 BookmarkBarView::DisableAnimationsForTesting(false); | 103 BookmarkBarView::DisableAnimationsForTesting(false); |
| 69 } | 104 } |
| 70 | 105 |
| 71 // Active window and focus testing is not reliable on Windows crbug.com/79493 | 106 // Active window and focus testing is not reliable on Windows crbug.com/79493 |
| (...skipping 10 matching lines...) Expand all Loading... |
| 82 | 117 |
| 83 // Focus starts in the location bar or one of its children. | 118 // Focus starts in the location bar or one of its children. |
| 84 EXPECT_TRUE(location_bar_view->Contains(focus_manager->GetFocusedView())); | 119 EXPECT_TRUE(location_bar_view->Contains(focus_manager->GetFocusedView())); |
| 85 | 120 |
| 86 chrome::ToggleFullscreenMode(browser()); | 121 chrome::ToggleFullscreenMode(browser()); |
| 87 EXPECT_TRUE(browser_view->IsFullscreen()); | 122 EXPECT_TRUE(browser_view->IsFullscreen()); |
| 88 | 123 |
| 89 // Focus is released from the location bar. | 124 // Focus is released from the location bar. |
| 90 EXPECT_FALSE(location_bar_view->Contains(focus_manager->GetFocusedView())); | 125 EXPECT_FALSE(location_bar_view->Contains(focus_manager->GetFocusedView())); |
| 91 } | 126 } |
| OLD | NEW |