Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: chrome/browser/net/chrome_network_delegate.cc

Issue 1368383003: Only notify extensions about the end of a network request when it started (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/chrome_network_delegate.cc
diff --git a/chrome/browser/net/chrome_network_delegate.cc b/chrome/browser/net/chrome_network_delegate.cc
index 8fd2976e149934d21be6e42ac73a1bc1ea23639f..bedcdd6c370f54a17f128a89234986e4b47ed4f2 100644
--- a/chrome/browser/net/chrome_network_delegate.cc
+++ b/chrome/browser/net/chrome_network_delegate.cc
@@ -535,7 +535,11 @@ void ChromeNetworkDelegate::OnCompleted(net::URLRequest* request,
domain_reliability_monitor_->OnCompleted(request, started);
RecordRequestSourceBandwidth(request, started);
extensions_delegate_->ForwardProxyErrors(request);
- extensions_delegate_->ForwardDoneRequestStatus(request);
+
+ // The ChromeExtensionNetworkDelegate only expects to be notified about the
+ // end of requests that were actually started.
+ if (started)
+ extensions_delegate_->ForwardDoneRequestStatus(request);
}
void ChromeNetworkDelegate::OnURLRequestDestroyed(net::URLRequest* request) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698