Only notify extensions about the end of a network request when it started

chrome/browser/net/chrome_network_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/chrome_network_delegate.h"
 
 #include <stdlib.h>
 
 #include <vector>
 
@@ skipping 373 matching lines @@
                                     &request->url().possibly_invalid_spec()));
     return error;
   }
 #endif
 
   // TODO(mmenke): Remove ScopedTracker below once crbug.com/456327 is fixed.
   tracked_objects::ScopedTracker tracking_profile2(
       FROM_HERE_WITH_EXPLICIT_FUNCTION(
           "456327 URLRequest::ChromeNetworkDelegate::OnBeforeURLRequest 2"));
 
   extensions_delegate_->ForwardStartRequestStatus(request);

[mmenke, 2015/09/28 17:47:40]

I think it we always called this in wrapped callback (regardless of
force_safe_search) or when rv below was net::OK, everything would be fine,
though that does seem a bit ugly.

[mmenke, 2015/09/28 17:48:34]

That "or" means "and" (Since doing both will make sure it's invoked exactly once
for every request that's actually started)

 
   if (!enable_referrers_->GetValue())
     request->SetReferrer(std::string());
   if (enable_do_not_track_ && enable_do_not_track_->GetValue())
     request->SetExtraRequestHeaderByName(kDNTHeader, "1", true /* override */);
 
   // TODO(mmenke): Remove ScopedTracker below once crbug.com/456327 is fixed.
   tracked_objects::ScopedTracker tracking_profile3(
       FROM_HERE_WITH_EXPLICIT_FUNCTION(
           "456327 URLRequest::ChromeNetworkDelegate::OnBeforeURLRequest 3"));
@@ skipping 123 matching lines @@
   } else if (request->status().status() == net::URLRequestStatus::FAILED ||
              request->status().status() == net::URLRequestStatus::CANCELED) {
     extensions_delegate_->OnCompleted(request, started);
   } else {
     NOTREACHED();
   }
   if (domain_reliability_monitor_)
     domain_reliability_monitor_->OnCompleted(request, started);
   RecordRequestSourceBandwidth(request, started);
   extensions_delegate_->ForwardProxyErrors(request);
-  extensions_delegate_->ForwardDoneRequestStatus(request);
+
+  // The ChromeExtensionNetworkDelegate only expects to be notified about the
+  // end of requests that were actually started.
+  if (started)
+    extensions_delegate_->ForwardDoneRequestStatus(request);
 }
 
 void ChromeNetworkDelegate::OnURLRequestDestroyed(net::URLRequest* request) {
   extensions_delegate_->OnURLRequestDestroyed(request);
 }
 
 void ChromeNetworkDelegate::OnURLRequestJobOrphaned(net::URLRequest* request) {
   extensions_delegate_->OnURLRequestJobOrphaned(request);
 }
 
@@ skipping 153 matching lines @@
   return experimental_web_platform_features_enabled_;
 }
 
 bool ChromeNetworkDelegate::OnCancelURLRequestWithPolicyViolatingReferrerHeader(
     const net::URLRequest& request,
     const GURL& target_url,
     const GURL& referrer_url) const {
   ReportInvalidReferrerSend(target_url, referrer_url);
   return true;
 }