Issue 136833002: Remove redundant m_isItemCacheValid flag from LiveNodeListBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136833002: Remove redundant m_isItemCacheValid flag from LiveNodeListBase (Closed)

Created:
6 years, 11 months ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
esprehn, eseidel

CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove redundant m_isItemCacheValid flag from LiveNodeListBase We can simply do a null-check on the m_cachedItem pointer to check if the cache is valid. R=eseidel, esprehn BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165261

Patch Set 1 #

Patch Set 2 : More cleanup #

Patch Set 3 : No change #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -14 lines)			Patch
M	Source/core/dom/LiveNodeList.h	View	1	4 chunks	+1 line, -5 lines	0 comments	Download
M	Source/core/dom/LiveNodeList.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLCollection.h	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/HTMLCollection.cpp	View	1	4 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/136833002/110001

6 years, 11 months ago (2014-01-16 23:28:48 UTC) #5

Message was sent while issue was closed.

Change committed as 165261

Expand Messages | Collapse Messages