Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: Source/core/dom/LiveNodeList.cpp

Issue 136833002: Remove redundant m_isItemCacheValid flag from LiveNodeListBase (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: No change Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/LiveNodeList.h ('k') | Source/core/html/HTMLCollection.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2006, 2007, 2008, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 29 matching lines...) Expand all
40 Node& rootNode = this->rootNode(); 40 Node& rootNode = this->rootNode();
41 if (!rootNode.isContainerNode()) 41 if (!rootNode.isContainerNode())
42 return 0; 42 return 0;
43 return toContainerNode(&rootNode); 43 return toContainerNode(&rootNode);
44 } 44 }
45 45
46 void LiveNodeListBase::invalidateCache() const 46 void LiveNodeListBase::invalidateCache() const
47 { 47 {
48 m_cachedItem = 0; 48 m_cachedItem = 0;
49 m_isLengthCacheValid = false; 49 m_isLengthCacheValid = false;
50 m_isItemCacheValid = false;
51 } 50 }
52 51
53 void LiveNodeListBase::invalidateIdNameCacheMaps() const 52 void LiveNodeListBase::invalidateIdNameCacheMaps() const
54 { 53 {
55 ASSERT(hasIdNameCache()); 54 ASSERT(hasIdNameCache());
56 static_cast<const HTMLCollection*>(this)->invalidateIdNameCacheMaps(); 55 static_cast<const HTMLCollection*>(this)->invalidateIdNameCacheMaps();
57 } 56 }
58 57
59 Node* LiveNodeList::namedItem(const AtomicString& elementId) const 58 Node* LiveNodeList::namedItem(const AtomicString& elementId) const
60 { 59 {
(...skipping 13 matching lines...) Expand all
74 Node* node = item(i); 73 Node* node = item(i);
75 // FIXME: This should probably be using getIdAttribute instead of idForS tyleResolution. 74 // FIXME: This should probably be using getIdAttribute instead of idForS tyleResolution.
76 if (node->hasID() && toElement(node)->idForStyleResolution() == elementI d) 75 if (node->hasID() && toElement(node)->idForStyleResolution() == elementI d)
77 return node; 76 return node;
78 } 77 }
79 78
80 return 0; 79 return 0;
81 } 80 }
82 81
83 } // namespace WebCore 82 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/LiveNodeList.h ('k') | Source/core/html/HTMLCollection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698