Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1368223002: [GN]: BUILD file housecleaning (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 74dec11c3b8b645c5030e3925a0ce950d7167e6e..05ed1d205912d6907c7ba537d445f161cf6d3234 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -93,6 +93,7 @@ config("default_include_dirs") {
# where stuff should go. Put warning related stuff in the "warnings" config.
config("compiler") {
+ asmflags = []
cflags = []
cflags_c = []
cflags_cc = []
@@ -553,11 +554,17 @@ config("compiler") {
# Pass the same C/C++ flags to the objective C/C++ compiler.
cflags_objc += cflags_c
cflags_objcc += cflags_cc
+
+ if (is_posix) {
brettw 2015/09/28 19:44:52 Ditto. Also, it's probably worth mentioning that t
Bons 2015/09/28 20:15:39 Done.
+ asmflags += cflags
+ asmflags += cflags_c
+ }
}
config("compiler_arm_fpu") {
if (current_cpu == "arm" && !is_ios && !is_nacl) {
cflags = [ "-mfpu=$arm_fpu" ]
+ asmflags = cflags
}
}
@@ -906,6 +913,7 @@ config("no_chromium_code") {
"-Wno-deprecated",
]
}
+
cflags += default_warning_flags
cflags_cc += default_warning_flags_cc
}
@@ -1183,6 +1191,7 @@ config("symbols") {
if (use_debug_fission) {
cflags += [ "-gsplit-dwarf" ]
}
+ asmflags = cflags
brettw 2015/09/28 19:44:52 I think these are OK and don't need comments since
Bons 2015/09/28 20:15:39 Acknowledged.
ldflags = []
}
}
@@ -1205,6 +1214,7 @@ config("minimal_symbols") {
if (use_debug_fission) {
cflags += [ "-gsplit-dwarf" ]
}
+ asmflags = cflags
ldflags = []
}
}
@@ -1213,6 +1223,7 @@ config("minimal_symbols") {
config("no_symbols") {
if (!is_win) {
cflags = [ "-g0" ]
+ asmflags = cflags
}
}

Powered by Google App Engine
This is Rietveld 408576698