[GN]: BUILD file housecleaning

build/config/compiler/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/toolchain/ccache.gni")
 
 if (current_cpu == "arm") {
@@ skipping 75 matching lines @@
 }
 
 # compiler ---------------------------------------------------------------------
 #
 # Base compiler configuration.
 #
 # See also "runtime_library" below for related stuff and a discussion about
 # where stuff should go. Put warning related stuff in the "warnings" config.
 
 config("compiler") {
+  asmflags = []
   cflags = []
   cflags_c = []
   cflags_cc = []
   cflags_objc = []
   cflags_objcc = []
   ldflags = []
   defines = []
   configs = []
 
   # System-specific flags. If your compiler flags apply to one of the
@@ skipping 440 matching lines @@
     # TODO(mcgrathr) - the NaCl GCC toolchain doesn't support either gnu++11
     # or c++11; we technically don't need this toolchain any more, but there
     # are still a few buildbots using it, so until those are turned off
     # we need the !is_nacl clause and the (is_nacl && is_clang) clause, above.
     cflags_cc += [ "-std=c++11" ]
   }
 
   # Pass the same C/C++ flags to the objective C/C++ compiler.
   cflags_objc += cflags_c
   cflags_objcc += cflags_cc
+
+  if (is_posix) {

[brettw, 2015/09/28 19:44:52]

Ditto. Also, it's probably worth mentioning that the Windows assembler takes
different types of flags which is why we don't use it there.

[Bons, 2015/09/28 20:15:39]

Done.

+    asmflags += cflags
+    asmflags += cflags_c
+  }
 }
 
 config("compiler_arm_fpu") {
   if (current_cpu == "arm" && !is_ios && !is_nacl) {
     cflags = [ "-mfpu=$arm_fpu" ]
+    asmflags = cflags
   }
 }
 
 # runtime_library -------------------------------------------------------------
 #
 # Sets the runtime library and associated options.
 #
 # How do you determine what should go in here vs. "compiler" above? Consider if
 # a target might choose to use a different runtime library (ignore for a moment
 # if this is possible or reasonable on your system). If such a target would want
@@ skipping 328 matching lines @@
     cflags += [
       # Don't warn about printf format problems. This is off by default in gcc
       # but on in Ubuntu's gcc(!).
       "-Wno-format",
     ]
     cflags_cc += [
       # Don't warn about hash_map in third-party code.
       "-Wno-deprecated",
     ]
   }
+
   cflags += default_warning_flags
   cflags_cc += default_warning_flags_cc
 }
 
 # rtti ------------------------------------------------------------------------
 #
 # Allows turning Run-Time Type Identification on or off.
 
 config("rtti") {
   if (is_win) {
@@ skipping 257 matching lines @@
       # it all. This flag is incompatible with /PROFILE
       ldflags = [ "/DEBUG:FASTLINK" ]
     } else {
       ldflags = [ "/DEBUG" ]
     }
   } else {
     cflags = [ "-g2" ]
     if (use_debug_fission) {
       cflags += [ "-gsplit-dwarf" ]
     }
+    asmflags = cflags

[brettw, 2015/09/28 19:44:52]

I think these are OK and don't need comments since the configs are very focused
and it's obvious that this stuff should also apply to the assembler.

[Bons, 2015/09/28 20:15:39]

Acknowledged.

     ldflags = []
   }
 }
 
 # Minimal symbols.
 config("minimal_symbols") {
   if (is_win) {
     # Linker symbols for backtraces only.
     cflags = []
     if (is_win_fastlink) {
       # Tell VS 2015+ to create a PDB that references debug
       # information in .obj and .lib files instead of copying
       # it all. This flag is incompatible with /PROFILE
       ldflags = [ "/DEBUG:FASTLINK" ]
     } else {
       ldflags = [ "/DEBUG" ]
     }
   } else {
     cflags = [ "-g1" ]
     if (use_debug_fission) {
       cflags += [ "-gsplit-dwarf" ]
     }
+    asmflags = cflags
     ldflags = []
   }
 }
 
 # No symbols.
 config("no_symbols") {
   if (!is_win) {
     cflags = [ "-g0" ]
+    asmflags = cflags
   }
 }
 
 # Default symbols.
 config("default_symbols") {
   if (symbol_level == 0) {
     configs = [ ":no_symbols" ]
   } else if (symbol_level == 1) {
     configs = [ ":minimal_symbols" ]
   } else if (symbol_level == 2) {
     configs = [ ":symbols" ]
   } else {
     assert(false)
   }
 }