Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1368193002: Update page scale factor when layout updates (Closed)

Created:
5 years, 2 months ago by hush (inactive)
Modified:
5 years, 2 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update page scale factor when layout updates Page scale factor is updated when a main frame is committed. But that is not enough because when WebView is invisible, there won't be main frame commits. In order to get page scale factor updates even when WebView is invisible, check page scale factor change when the layout is updated. BUG=520089 Committed: https://crrev.com/f4e647c7be4db5bbea755042ee965b7accd2adf3 Cr-Commit-Position: refs/heads/master@{#351116}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use timer #

Total comments: 2

Patch Set 3 : de-dup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M android_webview/renderer/aw_render_view_ext.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/renderer/aw_render_view_ext.cc View 1 2 1 chunk +15 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
hush (inactive)
PTAL
5 years, 2 months ago (2015-09-26 01:53:52 UTC) #2
hush (inactive)
On 2015/09/26 01:53:52, hush wrote: > PTAL Per offline discussion, we can explore the possibility ...
5 years, 2 months ago (2015-09-26 02:13:11 UTC) #3
boliu
https://codereview.chromium.org/1368193002/diff/1/android_webview/renderer/aw_render_view_ext.cc File android_webview/renderer/aw_render_view_ext.cc (right): https://codereview.chromium.org/1368193002/diff/1/android_webview/renderer/aw_render_view_ext.cc#newcode191 android_webview/renderer/aw_render_view_ext.cc:191: CheckContentsSizeAndScale(); This implementation should be indentical to DidUpdateLayout, ie ...
5 years, 2 months ago (2015-09-28 16:33:06 UTC) #4
hush (inactive)
https://codereview.chromium.org/1368193002/diff/1/android_webview/renderer/aw_render_view_ext.cc File android_webview/renderer/aw_render_view_ext.cc (right): https://codereview.chromium.org/1368193002/diff/1/android_webview/renderer/aw_render_view_ext.cc#newcode191 android_webview/renderer/aw_render_view_ext.cc:191: CheckContentsSizeAndScale(); On 2015/09/28 16:33:05, boliu wrote: > This implementation ...
5 years, 2 months ago (2015-09-28 18:21:40 UTC) #5
boliu
lgtm % code dedup https://codereview.chromium.org/1368193002/diff/20001/android_webview/renderer/aw_render_view_ext.cc File android_webview/renderer/aw_render_view_ext.cc (right): https://codereview.chromium.org/1368193002/diff/20001/android_webview/renderer/aw_render_view_ext.cc#newcode191 android_webview/renderer/aw_render_view_ext.cc:191: if (check_contents_size_timer_.IsRunning()) no code duplication ...
5 years, 2 months ago (2015-09-28 18:30:47 UTC) #6
hush (inactive)
https://codereview.chromium.org/1368193002/diff/20001/android_webview/renderer/aw_render_view_ext.cc File android_webview/renderer/aw_render_view_ext.cc (right): https://codereview.chromium.org/1368193002/diff/20001/android_webview/renderer/aw_render_view_ext.cc#newcode191 android_webview/renderer/aw_render_view_ext.cc:191: if (check_contents_size_timer_.IsRunning()) On 2015/09/28 18:30:47, boliu wrote: > no ...
5 years, 2 months ago (2015-09-28 18:34:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368193002/40001
5 years, 2 months ago (2015-09-28 18:42:57 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-28 19:33:38 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 19:34:54 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f4e647c7be4db5bbea755042ee965b7accd2adf3
Cr-Commit-Position: refs/heads/master@{#351116}

Powered by Google App Engine
This is Rietveld 408576698