Update page scale factor when layout updates

android_webview/renderer/aw_render_view_ext.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/renderer/aw_render_view_ext.h"
 
 #include <string>
 
 #include "android_webview/common/aw_hit_test_data.h"
 #include "android_webview/common/render_view_messages.h"
@@ skipping 170 matching lines @@
       blink::WebDocument document = webview->mainFrame()->document();
       const blink::WebElement child_img = GetImgChild(document);
       hasImages = !child_img.isNull();
     }
   }
   Send(new AwViewHostMsg_DocumentHasImagesResponse(routing_id(), id,
                                                    hasImages));
 }
 
 void AwRenderViewExt::DidCommitCompositorFrame() {
-  UpdatePageScaleFactor();
+  if (check_contents_size_timer_.IsRunning())

[boliu, 2015/09/28 18:30:47]

no code duplication so close! factor out into a private method

[hush (inactive), 2015/09/28 18:34:39]

Done.

+    return;
+
+  check_contents_size_timer_.Start(FROM_HERE,
+                                   base::TimeDelta::FromMilliseconds(0), this,
+                                   &AwRenderViewExt::CheckContentsSizeAndScale);
 }
 
 void AwRenderViewExt::DidUpdateLayout() {
   if (check_contents_size_timer_.IsRunning())
     return;
 
   check_contents_size_timer_.Start(FROM_HERE,
                                    base::TimeDelta::FromMilliseconds(0), this,
-                                   &AwRenderViewExt::CheckContentsSize);
+                                   &AwRenderViewExt::CheckContentsSizeAndScale);
 }
 
-void AwRenderViewExt::UpdatePageScaleFactor() {
-  if (page_scale_factor_ != render_view()->GetWebView()->pageScaleFactor()) {
-    page_scale_factor_ = render_view()->GetWebView()->pageScaleFactor();
+void AwRenderViewExt::CheckContentsSizeAndScale() {
+  blink::WebView* webview = render_view()->GetWebView();
+  if (!webview)
+    return;
+
+  if (page_scale_factor_ != webview->pageScaleFactor()) {
+    page_scale_factor_ = webview->pageScaleFactor();
     Send(new AwViewHostMsg_PageScaleFactorChanged(routing_id(),
                                                   page_scale_factor_));
   }
-}
-
-void AwRenderViewExt::CheckContentsSize() {
-  if (!render_view()->GetWebView())
-    return;
 
   gfx::Size contents_size;
 
-  blink::WebFrame* main_frame = render_view()->GetWebView()->mainFrame();
+  blink::WebFrame* main_frame = webview->mainFrame();
   if (main_frame)
     contents_size = main_frame->contentsSize();
 
   // Fall back to contentsPreferredMinimumSize if the mainFrame is reporting a
   // 0x0 size (this happens during initial load).
   if (contents_size.IsEmpty()) {
-    contents_size = render_view()->GetWebView()->contentsPreferredMinimumSize();
+    contents_size = webview->contentsPreferredMinimumSize();
   }
 
   if (contents_size == last_sent_contents_size_)
     return;
 
   last_sent_contents_size_ = contents_size;
   Send(new AwViewHostMsg_OnContentsSizeChanged(routing_id(), contents_size));
 }
 
 void AwRenderViewExt::Navigate(const GURL& url) {
@@ skipping 88 matching lines @@
 void AwRenderViewExt::OnSmoothScroll(int target_x,
                                      int target_y,
                                      long duration_ms) {
   if (!render_view() || !render_view()->GetWebView())
     return;
 
   render_view()->GetWebView()->smoothScroll(target_x, target_y, duration_ms);
 }
 
 }  // namespace android_webview