Issue 136793026: Mojo: Add leak detection to mojo::embedder::test::Shutdown().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136793026: Mojo: Add leak detection to mojo::embedder::test::Shutdown(). (Closed)

Created:
6 years, 11 months ago by viettrungluu

Modified:
6 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Add leak detection to mojo::embedder::test::Shutdown(). Don't hook up Init()/Shutdown() to our test harnesses yet, because things blow up (we currently have singletons that will hold handles across tests). R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245605

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -8 lines)			Patch
M	mojo/system/core_impl.h	View	3 chunks	+8 lines, -2 lines	1 comment	Download
M	mojo/system/embedder/embedder_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/embedder/test_embedder.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	mojo/system/embedder/test_embedder.cc	View	1 chunk	+26 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/136793026/diff/1/mojo/system/core_impl.h File mojo/system/core_impl.h (right): https://codereview.chromium.org/136793026/diff/1/mojo/system/core_impl.h#newcode25 mojo/system/core_impl.h:25: bool ShutdownCheckNoLeaks(CoreImpl*); I believe the style guide says ...

6 years, 11 months ago (2014-01-17 20:29:00 UTC) #2

viettrungluu

6 years, 11 months ago (2014-01-17 20:36:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r245605 (presubmit successful).

Expand Messages | Collapse Messages