Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: mojo/system/embedder/test_embedder.cc

Issue 136793026: Mojo: Add leak detection to mojo::embedder::test::Shutdown(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/system/embedder/test_embedder.h" 5 #include "mojo/system/embedder/test_embedder.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/macros.h"
8 #include "mojo/system/core_impl.h" 9 #include "mojo/system/core_impl.h"
9 10
10 namespace mojo { 11 namespace mojo {
12
13 namespace system {
14 namespace internal {
15
16 bool ShutdownCheckNoLeaks(CoreImpl* core_impl) {
17 // No point in taking the lock.
18 if (core_impl->handle_table_.empty())
19 return true;
20
21 for (CoreImpl::HandleTableMap::const_iterator it =
22 core_impl->handle_table_.begin();
23 it != core_impl->handle_table_.end();
24 ++it) {
25 LOG(ERROR) << "Mojo embedder shutdown: Leaking handle " << (*it).first;
26 }
27 return false;
28 }
29
30 } // namespace internal
31 } // namespace system
32
11 namespace embedder { 33 namespace embedder {
12 namespace test { 34 namespace test {
13 35
14 void Shutdown() { 36 bool Shutdown() {
15 system::CoreImpl* core_impl = static_cast<system::CoreImpl*>(Core::Get()); 37 system::CoreImpl* core_impl = static_cast<system::CoreImpl*>(Core::Get());
16 CHECK(core_impl); 38 CHECK(core_impl);
17 Core::Reset(); 39 Core::Reset();
18 40
19 // TODO(vtl): Check for leaks, etc. 41 bool rv = system::internal::ShutdownCheckNoLeaks(core_impl);
20
21 delete core_impl; 42 delete core_impl;
43 return rv;
22 } 44 }
23 45
24 } // namespace test 46 } // namespace test
25 } // namespace embedder 47 } // namespace embedder
48
26 } // namespace mojo 49 } // namespace mojo
OLDNEW
« mojo/system/core_impl.h ('K') | « mojo/system/embedder/test_embedder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698