Issue 136793020: Get the proper Mac SDK path for the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136793020: Get the proper Mac SDK path for the GN build. (Closed)

Created:
6 years, 11 months ago by brettw

Modified:
6 years, 11 months ago

Reviewers:
Nico, (unused - use chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Get the proper Mac SDK path for the GN build. This gets the path from xcodebuild rather than hardcoding it in the .gn files. R=thakis BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245403

Patch Set 1 #

Total comments: 2

Patch Set 2 : Better comment. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -6 lines)			Patch
	M	build/config/mac/mac_sdk.gni	View	1	1 chunk	+13 lines, -6 lines	0 comments	Download
	M	build/mac/find_sdk.py	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm https://codereview.chromium.org/136793020/diff/1/build/config/mac/mac_sdk.gni File build/config/mac/mac_sdk.gni (right): https://codereview.chromium.org/136793020/diff/1/build/config/mac/mac_sdk.gni#newcode27 build/config/mac/mac_sdk.gni:27: # TODO(brettw) when everybody moves to XCode 5 ...

6 years, 11 months ago (2014-01-16 22:52:57 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/136793020/50001

6 years, 11 months ago (2014-01-16 23:20:18 UTC) #3

Message was sent while issue was closed.

Change committed as 245403

Expand Messages | Collapse Messages