Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: build/config/mac/mac_sdk.gni

Issue 136793020: Get the proper Mac SDK path for the GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Better comment. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/mac/find_sdk.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/mac_sdk.gni
diff --git a/build/config/mac/mac_sdk.gni b/build/config/mac/mac_sdk.gni
index 007e037f35a6450d06c08fe804529f7184686e97..770a06e95aa4da748bf4eb422c0af8384d2c3916 100644
--- a/build/config/mac/mac_sdk.gni
+++ b/build/config/mac/mac_sdk.gni
@@ -12,16 +12,23 @@ declare_args() {
mac_sdk_path = ""
}
+find_sdk_args = [ "--print_sdk_path" ]
if (is_chrome_branded && is_official_build) {
- find_sdk_args = [ "--verify", mac_sdk_min "--sdk_path=" + mac_sdk_path ]
+ find_sdk_args += [ "--verify", mac_sdk_min "--sdk_path=" + mac_sdk_path ]
} else {
- find_sdk_args = [ mac_sdk_min ]
+ find_sdk_args += [ mac_sdk_min ]
}
-# Use "list lines" and take the first to get version string without a newline.
+# The tool will print the SDK path on the first line, and the version on the
+# second line.
find_sdk_lines =
exec_script("//build/mac/find_sdk.py", find_sdk_args, "list lines")
-mac_sdk_version = find_sdk_lines[0]
+mac_sdk_version = find_sdk_lines[1]
if (mac_sdk_path == "") {
- mac_sdk_root = "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX"
- mac_sdk_path = mac_sdk_root + mac_sdk_version + ".sdk"
+ # TODO(brettw) http://crbug.com/335325 when everybody moves to XCode 5 we
+ # can remove the --print_sdk_path argument to find_sdk and instead just use
+ # the following two lines to get the path. Although it looks longer here, it
+ # saves forking a process in find_sdk.py so will be faster.
+ #mac_sdk_root = "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX"
+ #mac_sdk_path = mac_sdk_root + mac_sdk_version + ".sdk"
+ mac_sdk_path = find_sdk_lines[0]
}
« no previous file with comments | « no previous file | build/mac/find_sdk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698