Issue 136793004: Only include ash_strings if use_ash==1.

Issue 136793004: Only include ash_strings if use_ash==1. (Closed)

Created:
6 years, 11 months ago by aurimas (slooooooooow)

Modified:
6 years, 11 months ago

Reviewers:
Nico, newt (away)

CC:
chromium-reviews, Zachary Kuznia

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Only include ash_strings if use_ash==1. ash_strings where included in Android build and none of them are actually used. Restrict the include to only ash builds. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245085

Patch Set 1 #

Patch Set 2 : Update the rebase python scripts #

Patch Set 3 : Fixed USE_ASH assignment in python #

Total comments: 2

Patch Set 4 : Fixed the comparison #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -8 lines)			Patch
M	chrome/chrome_repack_locales.gypi	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_repack_pseudo_locales.gypi	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_resources.gyp	View	2	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/tools/build/repack_locales.py	View	1 2 3	6 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

aurimas (slooooooooow)

Hey Nico, Please take a look at this CL. Thanks, Aurimas

6 years, 11 months ago (2014-01-14 02:30:57 UTC) #1

aurimas (slooooooooow)

I had to change the repack_locales.py script as well. +newt to review that change

6 years, 11 months ago (2014-01-14 18:41:34 UTC) #3

Nico

https://codereview.chromium.org/136793004/diff/120001/chrome/tools/build/repack_locales.py File chrome/tools/build/repack_locales.py (right): https://codereview.chromium.org/136793004/diff/120001/chrome/tools/build/repack_locales.py#newcode194 chrome/tools/build/repack_locales.py:194: USE_ASH = options.use_ash == 1 Is this ever true? ...

6 years, 11 months ago (2014-01-14 19:14:01 UTC) #5

aurimas (slooooooooow)

6 years, 11 months ago (2014-01-14 19:30:36 UTC) #6

aurimas (slooooooooow)

I just compiled for ChromeOS and it seems like ash strings are still there (yay!).

6 years, 11 months ago (2014-01-14 19:36:41 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/136793004/180001

6 years, 11 months ago (2014-01-14 20:25:31 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/136793004/180001

6 years, 11 months ago (2014-01-14 23:25:16 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/136793004/180001

6 years, 11 months ago (2014-01-15 02:54:35 UTC) #10

Message was sent while issue was closed.

Change committed as 245085

Expand Messages | Collapse Messages