Only include ash_strings if use_ash==1.

chrome/tools/build/repack_locales.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Helper script to repack paks for a list of locales.
 
 Gyp doesn't have any built-in looping capability, so this just provides a way to
 loop over a list of locales when repacking pak files, thus avoiding a
 proliferation of mostly duplicate, cut-n-paste gyp actions.
@@ skipping 11 matching lines @@
 BRANDING = None
 
 # Some build paths defined by gyp.
 GRIT_DIR = None
 SHARE_INT_DIR = None
 INT_DIR = None
 
 # The target platform. If it is not defined, sys.platform will be used.
 OS = None
 
+USE_ASH = False
+
 # Extra input files.
 EXTRA_INPUT_FILES = []
 
 class Usage(Exception):
   def __init__(self, msg):
     self.msg = msg
 
 
 def calc_output(locale):
   """Determine the file that will be generated for the given locale."""
@@ skipping 25 matching lines @@
 
   #e.g. '<(grit_out_dir)/platform_locale_settings_da.pak'
   inputs.append(os.path.join(GRIT_DIR,
                 'platform_locale_settings_%s.pak' % locale))
 
   #e.g. '<(SHARED_INTERMEDIATE_DIR)/components/strings/
   # component_strings_da.pak',
   inputs.append(os.path.join(SHARE_INT_DIR, 'components', 'strings',
                 'component_strings_%s.pak' % locale))
 
+  if USE_ASH:
+    #e.g. '<(SHARED_INTERMEDIATE_DIR)/ash_strings/ash_strings_da.pak',
+    inputs.append(os.path.join(SHARE_INT_DIR, 'ash_strings',
+                  'ash_strings_%s.pak' % locale))
+
   if OS != 'ios':
     #e.g. '<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_strings_da.pak'
     inputs.append(os.path.join(SHARE_INT_DIR, 'webkit',
                   'webkit_strings_%s.pak' % locale))
 
     #e.g. '<(SHARED_INTERMEDIATE_DIR)/ui/ui_strings_da.pak',
     inputs.append(os.path.join(SHARE_INT_DIR, 'ui', 'ui_strings',
                   'ui_strings_%s.pak' % locale))
 
-    #e.g. '<(SHARED_INTERMEDIATE_DIR)/ash_strings/ash_strings_da.pak',
-    inputs.append(os.path.join(SHARE_INT_DIR, 'ash_strings',
-                  'ash_strings_%s.pak' % locale))
-
     #e.g. '<(SHARED_INTERMEDIATE_DIR)/device/bluetooth/strings/
     # device_bluetooth_strings_da.pak',
     inputs.append(os.path.join(SHARE_INT_DIR, 'device', 'bluetooth', 'strings',
                   'device_bluetooth_strings_%s.pak' % locale))
 
     #e.g. '<(SHARED_INTERMEDIATE_DIR)/ui/app_locale_settings_da.pak',
     inputs.append(os.path.join(SHARE_INT_DIR, 'ui', 'app_locale_settings',
                   'app_locale_settings_%s.pak' % locale))
 
   #e.g. '<(grit_out_dir)/google_chrome_strings_da.pak'
@@ skipping 45 matching lines @@
     output = calc_output(locale)
     data_pack.DataPack.RePack(output, inputs)
 
 
 def DoMain(argv):
   global BRANDING
   global GRIT_DIR
   global SHARE_INT_DIR
   global INT_DIR
   global OS
+  global USE_ASH
   global EXTRA_INPUT_FILES
 
   parser = optparse.OptionParser("usage: %prog [options] locales")
   parser.add_option("-i", action="store_true", dest="inputs", default=False,
                     help="Print the expected input file list, then exit.")
   parser.add_option("-o", action="store_true", dest="outputs", default=False,
                     help="Print the expected output file list, then exit.")
   parser.add_option("-g", action="store", dest="grit_dir",
                     help="GRIT build files output directory.")
   parser.add_option("-x", action="store", dest="int_dir",
                     help="Intermediate build files output directory.")
   parser.add_option("-s", action="store", dest="share_int_dir",
                     help="Shared intermediate build files output directory.")
   parser.add_option("-b", action="store", dest="branding",
                     help="Branding type of this build.")
   parser.add_option("-e", action="append", dest="extra_input", default=[],
                     help="Full path to an extra input pak file without the\
                          locale suffix and \".pak\" extension.")
   parser.add_option("-p", action="store", dest="os",
                     help="The target OS. (e.g. mac, linux, win, etc.)")
+  parser.add_option("--use-ash", action="store", dest="use_ash",
+                    help="Whether to include ash strings")
   options, locales = parser.parse_args(argv)
 
   if not locales:
     parser.error('Please specificy at least one locale to process.\n')
 
   print_inputs = options.inputs
   print_outputs = options.outputs
   GRIT_DIR = options.grit_dir
   INT_DIR = options.int_dir
   SHARE_INT_DIR = options.share_int_dir
   BRANDING = options.branding
   EXTRA_INPUT_FILES = options.extra_input
   OS = options.os
+  USE_ASH = options.use_ash == 1

[Nico, 2014/01/14 19:14:01]

Is this ever true? options are strings, no?
False

[aurimas (slooooooooow), 2014/01/14 19:30:36]

Good catch. Fixed.

 
   if not OS:
     if sys.platform == 'darwin':
       OS = 'mac'
     elif sys.platform.startswith('linux'):
       OS = 'linux'
     elif sys.platform in ('cygwin', 'win32'):
       OS = 'win'
     else:
       OS = sys.platform
@@ skipping 11 matching lines @@
 
   if print_outputs:
     return list_outputs(locales)
 
   return repack_locales(locales)
 
 if __name__ == '__main__':
   results = DoMain(sys.argv[1:])
   if results:
     print results