Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 136783005: Acquire lock in Args::SetSystemVars() (Closed)

Created:
6 years, 10 months ago by Jens Widell
Modified:
6 years, 10 months ago
Reviewers:
halyavin, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Acquire lock in Args::SetSystemVars() Since the function manipulates Args::declared_arguments_, it needs to hold the lock to avoid heap corruption. BUG=335587 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247710

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/gn/args.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jens Widell
Uploading trivial fix based on halyavin's comment in crbug.com/335587. Matches the crashes I've reproduced, and ...
6 years, 10 months ago (2014-01-29 14:03:28 UTC) #1
brettw
Sweet! LGTM
6 years, 10 months ago (2014-01-29 14:11:15 UTC) #2
Jens Widell
On 2014/01/29 14:11:15, brettw wrote: > Sweet! LGTM Thanks. How does one commit a GN ...
6 years, 10 months ago (2014-01-29 14:20:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/136783005/1
6 years, 10 months ago (2014-01-29 14:23:17 UTC) #4
halyavin
On 2014/01/29 14:20:42, Jens Lindström wrote: > On 2014/01/29 14:11:15, brettw wrote: > > Sweet! ...
6 years, 10 months ago (2014-01-29 14:25:26 UTC) #5
Jens Widell
On 2014/01/29 14:25:26, halyavin wrote: > On 2014/01/29 14:20:42, Jens Lindström wrote: > > the ...
6 years, 10 months ago (2014-01-29 14:28:55 UTC) #6
commit-bot: I haz the power
Change committed as 247710
6 years, 10 months ago (2014-01-29 17:08:05 UTC) #7
brettw
6 years, 10 months ago (2014-01-30 00:26:05 UTC) #8
Message was sent while issue was closed.
On 2014/01/29 17:08:05, I haz the power (commit-bot) wrote:
> Change committed as 247710

I need to push new binaries. Unfortunately, I probably won't be able to do this 
until early next week.

Powered by Google App Engine
This is Rietveld 408576698