tools/gn/args.cc - Issue 136783005: Acquire lock in Args::SetSystemVars()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/args.cc

Issue 136783005: Acquire lock in Args::SetSystemVars() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/args.cc

diff --git a/tools/gn/args.cc b/tools/gn/args.cc

index 5a031c78993fc823fc9f64ebe9376de58d1e1fae..795c1495669c0f444b5dd32670059fdfdea97a75 100644

--- a/tools/gn/args.cc

+++ b/tools/gn/args.cc

@@ -163,6 +163,8 @@ bool Args::VerifyAllOverridesUsed(Err* err) const {

}

void Args::SetSystemVars(Scope* dest) const {

+ base::AutoLock lock(lock_);

// Host OS.

const char* os = NULL;

#if defined(OS_WIN)

« no previous file with comments | « no previous file | no next file » | no next file with comments »