third_party/WebKit/LayoutTests/fast/canvas/bug535171.html - Issue 1367743002: Fix assert when resolving font on canvas with dirty shadow distribution

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/bug535171.html

Issue 1367743002: Fix assert when resolving font on canvas with dirty shadow distribution (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <script>

	3 //Test passes by not crashing
	rune 2015/09/23 22:55:41 I would have put the pass condition in a <p> to ma I would have put the pass condition in a <p> to make the pass condition clear to someone opening the test manually. Justin Novosad 2015/09/24 19:39:11 Yep I would have done that too, but it does not wo Show quoted text On 2015/09/23 22:55:41, rune wrote: > I would have put the pass condition in a <p> to make the pass condition clear to > someone opening the test manually. Yep I would have done that too, but it does not work because of the shadowDOM. I also tried putting the <p> in the shadow's innerHTML, but that does not work either. I am guessing that is because dumpAsText does not traverse the shadowDOM, or something like that.
	4 if (window.testRunner) {

	5 testRunner.dumpAsText();

	6 }

	7 document.documentElement.createShadowRoot();

	8 var canvas = document.createElement('canvas');

	9 var context = canvas.getContext('2d');

	10 context.font = 'italic 40pt Calibri';

	11 </script>

OLD	NEW