Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1367543002: Revert of bugging for ipc related crash. (Closed)

Created:
5 years, 3 months ago by erikchen
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland debugging for ipc related crash. Reason for revert: Once again, seeing crashes. https://crash.corp.google.com/browse?q=product.name%3D%27Chrome%27%20AND%20product.version%3D%2747.0.2517.0%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27renderer%27 Original issue's description: > Reland of land debugging for ipc related crash. (patchset #1 id:1 of https://codereview.chromium.org/1354863004/ ) > > Reason for revert: > Relanding this CL, as I don't think it will actually cause crashes. > > https://code.google.com/p/chromium/issues/detail?id=524032#c27 > > Original issue's description: > > Revert of Reland debugging for ipc related crash. (patchset #1 id:1 of https://codereview.chromium.org/1354063002/ ) > > > > Reason for revert: > > Supposedly, this CL only changes the signature of the crash, not the presence of the crash. There is some (but not totally clear) evidence that this CL is causing a crash itself. > > > > https://code.google.com/p/chromium/issues/detail?id=527588#c32 > > > > Original issue's description: > > > Reland debugging for ipc related crash. > > > > > > This CL is almost identical to https://codereview.chromium.org/1350823002/. The > > > only difference is that the part of the CL that causes the crash has been > > > omitted. > > > > > > BUG=527588 > > > > > > Committed: https://crrev.com/a7502c6dff276bce3c76d680c5d613cb6ece19be > > > Cr-Commit-Position: refs/heads/master@{#349828} > > > > TBR=avi@chromium.org,tsepez@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=527588 > > > > Committed: https://crrev.com/dbc8c1869a4fd0493150c008106be720eba86205 > > Cr-Commit-Position: refs/heads/master@{#350062} > > TBR=avi@chromium.org,tsepez@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=527588 > > Committed: https://crrev.com/a8b611fd4d40c8be9d65a16853fcfb572e3302cd > Cr-Commit-Position: refs/heads/master@{#350203} TBR=avi@chromium.org,tsepez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=527588 Committed: https://crrev.com/fa2e4f2d931e0290ecab3df2e87b161795dfc7ac Cr-Commit-Position: refs/heads/master@{#350346}

Patch Set 1 #

Patch Set 2 : Rebase against top of tree. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -92 lines) Patch
M content/browser/browser_main_loop.cc View 1 3 chunks +0 lines, -6 lines 0 comments Download
M content/browser/loader/async_resource_handler.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 2 chunks +0 lines, -10 lines 0 comments Download
M content/child/resource_scheduling_filter.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M content/child/threaded_data_provider.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/resource_messages.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/common/resource_messages.cc View 1 1 chunk +0 lines, -16 lines 0 comments Download
M ipc/ipc_channel.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M ipc/ipc_channel_common.cc View 1 2 chunks +0 lines, -12 lines 0 comments Download
M ipc/ipc_channel_reader.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M ipc/ipc_channel_win.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M ipc/ipc_message.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
erikchen
Created Revert of bugging for ipc related crash.
5 years, 3 months ago (2015-09-23 16:46:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367543002/1
5 years, 3 months ago (2015-09-23 16:47:44 UTC) #2
commit-bot: I haz the power
Failed to commit the patch.
5 years, 3 months ago (2015-09-23 16:49:56 UTC) #4
Avi (use Gerrit)
lgtm
5 years, 3 months ago (2015-09-23 17:00:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367543002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367543002/220001
5 years, 3 months ago (2015-09-23 18:19:18 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:220001)
5 years, 3 months ago (2015-09-23 18:24:01 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 18:35:59 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa2e4f2d931e0290ecab3df2e87b161795dfc7ac
Cr-Commit-Position: refs/heads/master@{#350346}

Powered by Google App Engine
This is Rietveld 408576698