Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 1361903004: Add CHECKs to help debug crashes exposed by adding a member to IPC::Message::Header. (Closed)

Created:
5 years, 3 months ago by erikchen
Modified:
5 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@ipc_content_checks
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CHECKs to help debug crashes exposed by adding a member to IPC::Message::Header. This CL checks that the data_offset field of the ResourceMsg_DataReceived has the appropriate range in both the sender and the receiver of the IPC message. BUG=527588 Committed: https://crrev.com/01d2c16fa0ae1952af0d5519d134f944f898f70f Cr-Commit-Position: refs/heads/master@{#350421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/browser/loader/async_resource_handler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
erikchen
avi: Please review. This will tell us definitely whether anything funky is happening for some ...
5 years, 3 months ago (2015-09-23 18:23:17 UTC) #2
Avi (use Gerrit)
lgtm go for it
5 years, 3 months ago (2015-09-23 19:38:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361903004/1
5 years, 3 months ago (2015-09-23 21:42:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 00:50:34 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/01d2c16fa0ae1952af0d5519d134f944f898f70f Cr-Commit-Position: refs/heads/master@{#350421}
5 years, 3 months ago (2015-09-24 00:51:42 UTC) #7
erikchen
5 years, 2 months ago (2015-09-25 19:07:03 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1365963007/ by erikchen@chromium.org.

The reason for reverting is: Crashes have been exposed. This CL is no longer
needed..

Powered by Google App Engine
This is Rietveld 408576698