Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 136753013: rename tracing parameter to be more consistent with other methods (Closed)

Created:
6 years, 10 months ago by humper
Modified:
6 years, 10 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rename tracing parameter to be more consistent with other methods BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13287

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M include/utils/SkEventTracer.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/SkEventTracer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
humper
more small self-nits on the tracer
6 years, 10 months ago (2014-02-03 18:53:15 UTC) #1
bsalomon
lgtm
6 years, 10 months ago (2014-02-03 19:01:07 UTC) #2
humper
The CQ bit was checked by humper@google.com
6 years, 10 months ago (2014-02-03 19:06:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/136753013/1
6 years, 10 months ago (2014-02-03 19:06:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 19:12:50 UTC) #5
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
6 years, 10 months ago (2014-02-03 19:12:50 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:12:58 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:14:00 UTC) #8
humper
The CQ bit was checked by humper@google.com
6 years, 10 months ago (2014-02-03 19:15:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/136753013/150001
6 years, 10 months ago (2014-02-03 19:15:53 UTC) #10
commit-bot: I haz the power
Change committed as 13287
6 years, 10 months ago (2014-02-03 19:47:15 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:47:17 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 19:48:39 UTC) #13
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698