Issue 1367523010: [GN]: Remove dead code GetExtensionForOutputType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1367523010: [GN]: Remove dead code GetExtensionForOutputType (Closed)

Created:
5 years, 3 months ago by Bons

Modified:
5 years, 3 months ago

Reviewers:
Dirk Pranke, brettw

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[GN]: Remove dead code GetExtensionForOutputType BUG=none R=brettw@chromium.org,dpranke@chromium.org Committed: https://crrev.com/23dca52ade6cb7fbd30dbd95d35e5c398924acc6 Cr-Commit-Position: refs/heads/master@{#350641}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -57 lines)			Patch
	M	tools/gn/filesystem_utils.h	View		1 chunk	+0 lines, -9 lines	0 comments	Download
	M	tools/gn/filesystem_utils.cc	View		1 chunk	+0 lines, -48 lines	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367523010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367523010/1

5 years, 3 months ago (2015-09-24 19:41:45 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-24 20:13:04 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/23dca52ade6cb7fbd30dbd95d35e5c398924acc6
Cr-Commit-Position: refs/heads/master@{#350641}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages