Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: tools/gn/filesystem_utils.cc

Issue 1367523010: [GN]: Remove dead code GetExtensionForOutputType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/filesystem_utils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/filesystem_utils.cc
diff --git a/tools/gn/filesystem_utils.cc b/tools/gn/filesystem_utils.cc
index 79e77310d2588cba16d714aa95320eb91316f735..44de5adaa221492bd11c505317e4d392205be1d6 100644
--- a/tools/gn/filesystem_utils.cc
+++ b/tools/gn/filesystem_utils.cc
@@ -165,54 +165,6 @@ bool FilesystemStringsEqual(const base::FilePath::StringType& a,
} // namespace
-const char* GetExtensionForOutputType(Target::OutputType type,
- Settings::TargetOS os) {
- switch (os) {
- case Settings::MAC:
- switch (type) {
- case Target::EXECUTABLE:
- return "";
- case Target::SHARED_LIBRARY:
- return "dylib";
- case Target::STATIC_LIBRARY:
- return "a";
- default:
- NOTREACHED();
- }
- break;
-
- case Settings::WIN:
- switch (type) {
- case Target::EXECUTABLE:
- return "exe";
- case Target::SHARED_LIBRARY:
- return "dll.lib"; // Extension of import library.
- case Target::STATIC_LIBRARY:
- return "lib";
- default:
- NOTREACHED();
- }
- break;
-
- case Settings::LINUX:
- switch (type) {
- case Target::EXECUTABLE:
- return "";
- case Target::SHARED_LIBRARY:
- return "so";
- case Target::STATIC_LIBRARY:
- return "a";
- default:
- NOTREACHED();
- }
- break;
-
- default:
- NOTREACHED();
- }
- return "";
-}
-
std::string FilePathToUTF8(const base::FilePath::StringType& str) {
#if defined(OS_WIN)
return base::WideToUTF8(str);
« no previous file with comments | « tools/gn/filesystem_utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698