third_party/WebKit/Source/core/dom/NodeList.idl - Issue 1367523002: [dom] support iterable<> NodeList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/NodeList.idl

Issue 1367523002: [dom] support iterable<> NodeList (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/NodeList.idl

diff --git a/third_party/WebKit/Source/core/dom/NodeList.idl b/third_party/WebKit/Source/core/dom/NodeList.idl

index 5e549ca9eda012fa93a8b10c969edb7997428163..15fb98a8eea043fabfdc087c3c5e2ce386759cce 100644

--- a/third_party/WebKit/Source/core/dom/NodeList.idl

+++ b/third_party/WebKit/Source/core/dom/NodeList.idl

@@ -27,5 +27,5 @@

] interface NodeList {

getter Node? item(unsigned long index);

readonly attribute unsigned long length;

- // FIXME: iterable<Node>;

+ iterable<Node>;

esprehn 2015/10/03 05:07:45 Why can't you write [RuntimeEnabled=NodeListIterab

caitp (gmail) 2015/10/03 15:46:45 I wasn't familiar with the Blink approach to hidin

};