Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1367423002: [turbofan] Move node verification methods to the Verifier class. (Closed)

Created:
5 years, 2 months ago by Jarin
Modified:
5 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move node verification methods to the Verifier class. Committed: https://crrev.com/dac7c953768bb1741e8e7e72fc0e58e9414fae44 Cr-Commit-Position: refs/heads/master@{#30962}

Patch Set 1 #

Patch Set 2 : Tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -80 lines) Patch
M src/compiler/graph.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/compiler/graph-reducer.cc View 1 3 chunks +2 lines, -17 lines 0 comments Download
M src/compiler/node-properties.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/compiler/node-properties.cc View 3 chunks +2 lines, -49 lines 0 comments Download
M src/compiler/verifier.h View 1 2 chunks +24 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Could you take a look, please?
5 years, 2 months ago (2015-09-28 06:36:54 UTC) #2
Michael Starzinger
LGTM.
5 years, 2 months ago (2015-09-28 07:45:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367423002/20001
5 years, 2 months ago (2015-09-28 08:11:03 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 08:12:48 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 08:15:26 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/dac7c953768bb1741e8e7e72fc0e58e9414fae44
Cr-Commit-Position: refs/heads/master@{#30962}

Powered by Google App Engine
This is Rietveld 408576698