Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 1367333002: Remove WebDocument::createEvent. (Closed)

Created:
5 years, 2 months ago by esprehn
Modified:
5 years, 2 months ago
CC:
blink-reviews, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, jochen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebDocument::createEvent. We shouldn't expose the type unsafe API for creating events, instead lets expose constructors for the actual event objects. I also removed most of the functionality of WebDOMCustomEvent since it's only used by the IPCEcho testing system. As this system has no tests checked in and seems to be only used by local benchmarking we should probably remove it, but lets do that in a future patch. Committed: https://crrev.com/4aae4de1c3375d1f216dc0316c272414c5dd9b12 Cr-Commit-Position: refs/heads/master@{#351135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -202 lines) Patch
M components/html_viewer/html_frame.cc View 2 chunks +7 lines, -14 lines 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.cc View 1 chunk +1 line, -11 lines 0 comments Download
M content/renderer/pepper/message_channel.cc View 2 chunks +1 line, -11 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +6 lines, -11 lines 0 comments Download
M content/shell/renderer/ipc_echo.cc View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebDOMCustomEvent.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebDOMMessageEvent.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebDocument.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/Source/web/tests/CustomEventTest.cpp View 1 chunk +0 lines, -116 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebDOMCustomEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebDOMMessageEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/WebDocument.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367333002/1
5 years, 2 months ago (2015-09-26 03:36:48 UTC) #2
esprehn
5 years, 2 months ago (2015-09-26 03:37:12 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-26 05:33:01 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-09-28 11:30:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367333002/1
5 years, 2 months ago (2015-09-28 17:23:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 20:53:38 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 20:54:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4aae4de1c3375d1f216dc0316c272414c5dd9b12
Cr-Commit-Position: refs/heads/master@{#351135}

Powered by Google App Engine
This is Rietveld 408576698