Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1367333002: Remove WebDocument::createEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/message_channel.cc ('k') | content/shell/renderer/ipc_echo.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 5aed77678c39a1043d68ca080963acf06148d014..d07d63d833d5a54fc048389cc32e80329ff65256 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1748,17 +1748,6 @@ void RenderFrameImpl::OnPostMessageEvent(
serialized_script_value = WebSerializedScriptValue::fromString(params.data);
}
- // Create an event with the message. The next-to-last parameter to
- // initMessageEvent is the last event ID, which is not used with postMessage.
- WebDOMEvent event = frame_->document().createEvent("MessageEvent");
- WebDOMMessageEvent msg_event = event.to<WebDOMMessageEvent>();
- msg_event.initMessageEvent("message",
- // |canBubble| and |cancellable| are always false
- false, false,
- serialized_script_value,
- params.source_origin, source_frame,
- frame_->document(), "", channels);
-
// We must pass in the target_origin to do the security check on this side,
// since it may have changed since the original postMessage call was made.
WebSecurityOrigin target_origin;
@@ -1766,6 +1755,12 @@ void RenderFrameImpl::OnPostMessageEvent(
target_origin =
WebSecurityOrigin::createFromString(WebString(params.target_origin));
}
+
+ WebDOMMessageEvent msg_event(serialized_script_value,
+ params.source_origin,
+ source_frame,
+ frame_->document(),
+ channels);
frame_->dispatchMessageEventWithOriginCheck(target_origin, msg_event);
}
« no previous file with comments | « content/renderer/pepper/message_channel.cc ('k') | content/shell/renderer/ipc_echo.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698