fpdfsdk/include/javascript/JS_Runtime.h - Issue 1367033002: Pass v8::Isolate to PDFium at init time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/javascript/JS_Runtime.h

Issue 1367033002: Pass v8::Isolate to PDFium at init time. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: fix leak, clear globals while we're at it. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/include/javascript/JS_Runtime.h

diff --git a/fpdfsdk/include/javascript/JS_Runtime.h b/fpdfsdk/include/javascript/JS_Runtime.h

index 67ce9c04143cd92a30dc7455d905b42bddb99558..85b52f4ad21242c6f5be3d9110264b90d5152c64 100644

--- a/fpdfsdk/include/javascript/JS_Runtime.h

+++ b/fpdfsdk/include/javascript/JS_Runtime.h

@@ -55,7 +55,6 @@ class CJS_Runtime : public IFXJS_Runtime {

std::set<FieldEvent> m_FieldEventSet;

v8::Isolate* m_isolate;

bool m_isolateManaged;

- nonstd::unique_ptr<FXJS_ArrayBufferAllocator> m_pArrayBufferAllocator;

v8::Global<v8::Context> m_context;

};

« no previous file with comments | « no previous file | fpdfsdk/include/jsapi/fxjs_v8.h » ('j') | fpdfsdk/src/fpdfview.cpp » ('J')